Skip to content

Commit 49950d9

Browse files
committed
hotfix: update non-compression case register error (#14)
1 parent 39d929a commit 49950d9

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

byteps/mxnet/__init__.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ def _register_compressor(self, params, optimizer_params, compression_params):
253253
for _, param in params.items():
254254
# generic
255255
for item in check_list:
256-
if item in compression_params and compression_params[item]:
256+
if compression_params.get(item):
257257
if isinstance(compression_params[item], str):
258258
setattr(param, "byteps_%s_type" %
259259
item, compression_params[item])
@@ -270,12 +270,12 @@ def _register_compressor(self, params, optimizer_params, compression_params):
270270
setattr(param, "byteps_compressor_k",
271271
compression_params["k"])
272272

273-
if "momentum" in compression_params:
273+
if compression_params.get("momentum"):
274274
setattr(param, "byteps_momentum_mu",
275275
optimizer_params["momentum"])
276276

277277
# change
278-
if "momentum" in compression_params:
278+
if compression_params.get("momentum"):
279279
# 1bit compressor use an additional momentum for weight decay
280280
if compressor == "onebit" and "wd" in optimizer_params:
281281
intra_compressor = Compression.wdmom(

0 commit comments

Comments
 (0)