Remove heap size check when creating wasi ctx #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync up with upstream main branch
Fix dumplicated destroy shared memory's lock issue Add native symbol node to list head so as to lookup developer's registered node first
Fix duplicated destroy shared memory's lock issue (#514)
fix pthread library issues: (#522)
Fix auxiliary stack size not 16-byte aligned issue (#524)
Fix loader fail to lookup registered native symbol issue (#529)
add uvwasi implementation to support wasi on windows [experimental] (#534)
Fix windows aot loader fail to resolve symbol issue (#540)
platforms/nuttx: Add FPU relative macro for thumb vfp (#541)
Enhance ems memory allocator (#544)
Update global initialization process for latest spec cases (#553)
Fix app manager fail to install large app file issue (#555)
Enable SIMD by default for wamrc and iwasm (#559)
Enable to use BH_VPRINTF macro to redirect stdout output (#560)
wenyongh
referenced
this pull request
in wenyongh/wasm-micro-runtime
Mar 10, 2021
Remove heap size check when creating wasi ctx (#565)
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Remove check for heap_size==0 when creating wasi ctx, as the related data structures are allocated from global heap instead of app heap now, so it also works when app heap isn't created. Also add v128 type for Windows so as to fix wamrc compilation error in Windows platform. Signed-off-by: Wenyong Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove check for heap_size==0 when creating wasi ctx, as the related data structure are allocated from global heap instead of app heap now, so it also works when app heap isn't created.
Also add v128 type for Windows so as to fix wamrc compilation error in Windows platform.
Signed-off-by: Wenyong Huang [email protected]