-
Notifications
You must be signed in to change notification settings - Fork 732
CMakeLists.txt: Do not require C++ #3926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
By default, the project() CMake command defaults to C and C++. [1] Therefore, CMake might perform tests for both C and C++ compilers as part of the configuration phase. However, this has the consequence of the configuration phase to fail if the system does not have a C++ toolchain installed, even if C++ is not really used by the project. [1]: https://cmake.org/cmake/help/latest/command/project.html
Not true. like: ./libraries/wasi-nn/src/wasi_nn_tensorflowlite.cpp |
|
@midokura-xavi92 I'm closing the PR as it looks like there are indeed C++ files for AOT/JIT modes. Feel free to re-open the PR with more context though. |
|
Sorry for the delayed answer.
Let me rephrase: C++ is not really used by the top-level About the files listed above:
All these files are Therefore, these files have no effect on the top-level
This file is only used by Therefore, these files have no effect on the top-level
That said, if
Similarly, this Then, Given the rationale above, I will re-open this PR because IMHO it is still relevant. |
|
@loganek it looks like it is not possible for me to re-open this PR. Could you please re-open it? Thank you! |
|
@yamt the branch was force-pushed to include the suggestions related to |
|
i don't know why. but github has always been that way as far as i know. |
|
Superseded by #3956. |

By default, the project() CMake command defaults to C and C++. 1 Therefore, CMake might perform tests for both C and C++ compilers as part of the configuration phase.
However, this has the consequence of the configuration phase to fail if the system does not have a C++ toolchain installed, even if C++ is not really used by the project.