Create module hash for each module in SGX lib-rats #1745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current SGX lib-rats wasm module hash is stored in a global buffer, which may be overwritten if there are multiple wasm module loadings. We move the module hash into the enclave module to resolve the issue. And rename the RATS macro/variable in Makefile and Enclave.edl to make the code more consistent. And refine the sgx-ra sample document.
Contributor
Author
|
@zeuson0 @JamesMenetrey Could you help review the PR? Thanks in advance. |
zeuson0
approved these changes
Nov 24, 2022
JamesMenetrey
suggested changes
Nov 24, 2022
Contributor
JamesMenetrey
left a comment
JamesMenetrey
left a comment
There was a problem hiding this comment.
That sounds like a great addition, thanks! Here is my feedback.
| #endif | ||
|
|
||
| /* Destroy enclave module resources */ | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
I suggest we remove this blank line to match the other comments' style.
Comment on lines
19
to
20
| char * | ||
| wasm_runtime_get_module_hash(wasm_module_t module); |
Contributor
There was a problem hiding this comment.
Shouldn't we move this declaration to lib_rats_common.h?
Contributor
Author
There was a problem hiding this comment.
I move to wasm_export.h instead
Comment on lines
320
to
323
| extern "C" { | ||
| char * | ||
| wasm_runtime_get_module_hash(wasm_module_t module); | ||
| } |
Contributor
There was a problem hiding this comment.
Shouldn't we move this declaration to lib_rats_common.h?
Contributor
Author
There was a problem hiding this comment.
Move to wasm_export.h, since the function is implemented in this cpp file, if it isn't declared in .h file with extern "C" { .. }, it will be compiled as a c++ API, and eventually link error occurs.
Contributor
Author
Thanks for the comments! I addressed them with a patch set, could you review again? |
Contributor
|
This is great, thanks! |
JamesMenetrey
approved these changes
Nov 24, 2022
NingW101
pushed a commit
to NingW101/wasm-micro-runtime
that referenced
this pull request
Dec 1, 2022
…1745) Current SGX lib-rats wasm module hash is stored in a global buffer, which may be overwritten if there are multiple wasm module loadings. We move the module hash into the enclave module to resolve the issue. And rename the SGX_IPFS macro/variable in Makefile and Enclave.edl to make the code more consistent. And refine the sgx-ra sample document.
wenyongh
added a commit
that referenced
this pull request
Dec 6, 2022
Current SGX lib-rats wasm module hash is stored in a global buffer, which may be overwritten if there are multiple wasm module loadings. We move the module hash into the enclave module to resolve the issue. And rename the SGX_IPFS macro/variable in Makefile and Enclave.edl to make the code more consistent. And refine the sgx-ra sample document.
wenyongh
added a commit
that referenced
this pull request
Dec 19, 2022
Current SGX lib-rats wasm module hash is stored in a global buffer, which may be overwritten if there are multiple wasm module loadings. We move the module hash into the enclave module to resolve the issue. And rename the SGX_IPFS macro/variable in Makefile and Enclave.edl to make the code more consistent. And refine the sgx-ra sample document.
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…1745) Current SGX lib-rats wasm module hash is stored in a global buffer, which may be overwritten if there are multiple wasm module loadings. We move the module hash into the enclave module to resolve the issue. And rename the SGX_IPFS macro/variable in Makefile and Enclave.edl to make the code more consistent. And refine the sgx-ra sample document.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current SGX lib-rats wasm module hash is stored in a global buffer,
which may be overwritten if there are multiple wasm module loadings.
We move the module hash into the enclave module to resolve the issue.
And rename the SGX_IPFS macro/variable in Makefile and Enclave.edl to
make the code more consistent.
And refine the sgx-ra sample document.