Skip to content

Conversation

@wenyongh
Copy link
Contributor

@wenyongh wenyongh commented Apr 28, 2022

Fix wasm_application_execute_main/wasm_application_execute_func not waiting for
other threads to terminate in multi-thread mode, which causes that the exception
thrown by other threads may haven't been not spread the current main thread, and
cannot be detected by the caller, as reported in #1131.

@wenyongh wenyongh changed the title Fix execute_main not wait for other threads [WIP] Fix execute_main not wait for other threads Apr 28, 2022
@wenyongh wenyongh changed the title [WIP] Fix execute_main not wait for other threads Fix execute_main not wait for other threads Apr 29, 2022
Copy link
Collaborator

@xujuntwt95329 xujuntwt95329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit c6997aa into bytecodealliance:main Apr 29, 2022
wenyongh added a commit to wenyongh/wasm-micro-runtime that referenced this pull request Apr 29, 2022
Fix execute_main not wait for other threads (bytecodealliance#1137)
@wenyongh wenyongh deleted the fix_execute_main_nowait branch April 29, 2022 07:49
vickiegpt pushed a commit to vickiegpt/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
Fix wasm_application_execute_main/wasm_application_execute_func not waiting for
other threads to terminate in multi-thread mode, which causes that the exception
thrown by other threads may haven't been spreaded to current main thread, and
cannot be detected by the caller, as reported in bytecodealliance#1131.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants