About AOT memory access boundary check

[kkdomono]

for release: WAMR-04-15-2020
in core/iwasm/aot/aot_runtime.c

should it be:

app_offset < module_inst->heap_base_offset
app_offset + (int32)size >= (int32)module_inst->memory_data_size)

should it be:

module_inst->heap_base_offset <= app_offset

Since memory access for [0 -> size -1] is valid, is it right?

[wenyongh]

@linzhiping thanks a lot for finding the issue! It is really an issue, and some other codes have the same problem, we will fix them soon.

[wenyongh]

@linzhiping the patch has been merged, #249. Note for second condtion: app_offset + (int32)size > (int32)module_inst->memory_data_size), equal is allowed: suppose that memory_data_size is 65536, app_offset is 65535 and size is 1, it is OK to read one byte from offset 65535, and here app_offset + size == memory_data_size.