fix isssues detected by coverity

Author: lum1n0us

samples/socket-api/wasm-src/socket_opts.c

@@ -31,10 +31,18 @@ int
 set_and_get_bool_opt(int socket_fd, int level, int optname, int val)
 {
     int bool_opt = val;
+    int ret = -1;
     socklen_t opt_len = sizeof(bool_opt);
-    setsockopt(socket_fd, level, optname, &bool_opt, sizeof(bool_opt));
+
+    ret = setsockopt(socket_fd, level, optname, &bool_opt, sizeof(bool_opt));
+    if (ret != 0)
+        return !val;
+
     bool_opt = !bool_opt;
-    getsockopt(socket_fd, level, optname, &bool_opt, &opt_len);
+    ret = getsockopt(socket_fd, level, optname, &bool_opt, &opt_len);
+    if (ret != 0)
+        return !val;
+
     return bool_opt;
 }
 
@@ -197,11 +205,13 @@ main(int argc, char *argv[])
 
     // IP_TTL
     ttl = 8;
-    setsockopt(tcp_socket_fd, IPPROTO_IP, IP_TTL, &ttl, sizeof(ttl));
+    result = setsockopt(tcp_socket_fd, IPPROTO_IP, IP_TTL, &ttl, sizeof(ttl));
+    OPTION_ASSERT(result, 0, "IP_TIL");
     ttl = 0;
     opt_len = sizeof(ttl);
-    getsockopt(tcp_socket_fd, IPPROTO_IP, IP_TTL, &ttl, &opt_len);
+    result = getsockopt(tcp_socket_fd, IPPROTO_IP, IP_TTL, &ttl, &opt_len);
     OPTION_ASSERT(ttl, 8, "IP_TTL");
+    OPTION_ASSERT(result, 0, "IP_TIL");
 
     // IPV6_V6ONLY
     OPTION_ASSERT(
@@ -233,11 +243,15 @@ main(int argc, char *argv[])
 
     // IP_MULTICAST_TTL
     ttl = 8;
-    setsockopt(udp_socket_fd, IPPROTO_IP, IP_MULTICAST_TTL, &ttl, sizeof(ttl));
+    result = setsockopt(udp_socket_fd, IPPROTO_IP, IP_MULTICAST_TTL, &ttl,
+                        sizeof(ttl));
+    OPTION_ASSERT(result, 0, "IP_MULTICAST_TTL");
     ttl = 0;
     opt_len = sizeof(ttl);
-    getsockopt(udp_socket_fd, IPPROTO_IP, IP_MULTICAST_TTL, &ttl, &opt_len);
+    result =
+        getsockopt(udp_socket_fd, IPPROTO_IP, IP_MULTICAST_TTL, &ttl, &opt_len);
     OPTION_ASSERT(ttl, 8, "IP_MULTICAST_TTL");
+    OPTION_ASSERT(result, 0, "IP_MULTICAST_TTL");
 
     // IPV6_MULTICAST_LOOP
     OPTION_ASSERT(set_and_get_bool_opt(udp_ipv6_socket_fd, IPPROTO_IPV6,
@@ -248,12 +262,14 @@ main(int argc, char *argv[])
                   0, "IPV6_MULTICAST_LOOP disabled");
 
     // IPV6_JOIN_GROUP
-    setsockopt(udp_ipv6_socket_fd, IPPROTO_IPV6, IPV6_JOIN_GROUP, &mcast_ipv6,
-               sizeof(mcast_ipv6));
+    result = setsockopt(udp_ipv6_socket_fd, IPPROTO_IPV6, IPV6_JOIN_GROUP,
+                        &mcast_ipv6, sizeof(mcast_ipv6));
+    OPTION_ASSERT(result, 0, "IPV6_JOIN_GROUP");
 
     // IPV6_LEAVE_GROUP
-    setsockopt(udp_ipv6_socket_fd, IPPROTO_IPV6, IPV6_LEAVE_GROUP, &mcast_ipv6,
-               sizeof(mcast_ipv6));
+    result = setsockopt(udp_ipv6_socket_fd, IPPROTO_IPV6, IPV6_LEAVE_GROUP,
+                        &mcast_ipv6, sizeof(mcast_ipv6));
+    OPTION_ASSERT(result, 0, "IPV6_JOIN_GROUP");
 
     printf("[Client] Close sockets\n");
     close(tcp_socket_fd);

samples/socket-api/wasm-src/udp_client.c

@@ -73,6 +73,7 @@ main(int argc, char *argv[])
                    (struct sockaddr *)&server_address, &serverlen);
 
     if (ret > 0) {
+        buffer[ret] = '\0';
         printf("[Client] Buffer recieved: %s\n", buffer);
     }
 

samples/socket-api/wasm-src/udp_server.c

@@ -43,8 +43,8 @@ main(int argc, char *argv[])
     struct sockaddr_storage addr = { 0 };
     char *reply_message = "Hello from server";
     unsigned connections = 0;
-    char ip_string[64];
-    char buffer[1024];
+    char ip_string[64] = { 0 };
+    char buffer[1024] = { 0 };
 
     if (argc > 1 && strcmp(argv[1], "inet6") == 0) {
         af = AF_INET6;
@@ -79,6 +79,7 @@ main(int argc, char *argv[])
             perror("Read failed");
             goto fail;
         }
+        buffer[ret] = '\0';
 
         if (sockaddr_to_string((struct sockaddr *)&addr, ip_string,
                                sizeof(ip_string) / sizeof(ip_string[0]))