Skip to content

Commit 3693cbe

Browse files
authored
Suppress hadolint warnings for pinning versions part (#1511)
Related to #1418. Suppress hadolint warnings for pinning version. This is because these warnings are for reproducible builds. But for development and CIs, ordinary case developers have to use the latest packages.
1 parent 1ff04a9 commit 3693cbe

File tree

4 files changed

+10
-3
lines changed

4 files changed

+10
-3
lines changed

.devcontainer/Dockerfile

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ FROM mcr.microsoft.com/vscode/devcontainers/cpp:0-${VARIANT}
99
ARG DEBIAN_FRONTEND=noninteractive
1010
ENV TZ=Asian/Shanghai
1111

12+
# hadolint ignore=DL3008
1213
RUN apt-get update \
1314
&& apt-get install -y apt-transport-https apt-utils build-essential \
1415
ca-certificates curl g++-multilib git gnupg \
@@ -17,11 +18,12 @@ RUN apt-get update \
1718
software-properties-common tree tzdata \
1819
unzip valgrind vim wget zip --no-install-recommends \
1920
&& apt-get clean -y \
20-
&& rm -rf /var/lib/apt/lists/*
21+
&& rm -rf /var/lib/apt/lists/*
2122

2223
#
2324
# CMAKE (https://apt.kitware.com/)
2425
SHELL ["/bin/bash", "-o", "pipefail", "-c"]
26+
# hadolint ignore=DL3008
2527
RUN wget --progress=dot:giga -O - https://apt.kitware.com/keys/kitware-archive-latest.asc 2>/dev/null | gpg --dearmor - | tee /usr/share/keyrings/kitware-archive-keyring.gpg > /dev/null \
2628
&& echo 'deb [signed-by=/usr/share/keyrings/kitware-archive-keyring.gpg] https://apt.kitware.com/ubuntu/ bionic main' | tee /etc/apt/sources.list.d/kitware.list >/dev/null \
2729
&& apt-get update \
@@ -84,13 +86,15 @@ RUN wget --progress=dot:giga https://apt.llvm.org/llvm.sh \
8486

8587
#
8688
# Install pip
89+
# hadolint ignore=DL3008
8790
RUN apt-get update \
8891
&& apt-get install -y --reinstall python3-venv python3-pip --no-install-recommends \
8992
&& apt-get clean -y \
90-
&& rm -rf /var/lib/apt/lists/*
93+
&& rm -rf /var/lib/apt/lists/*
9194

9295
#
9396
# Install required python packages
97+
# hadolint ignore=DL3013
9498
RUN python3 -m pip install --no-cache-dir --upgrade pip \
9599
&& pip3 install --no-cache-dir --user black nose pycparser pylint
96100

test-tools/IoT-APP-Store-Demo/wasm_django/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ FROM python:3.5
33
WORKDIR /app
44
COPY . /app
55

6+
# hadolint ignore=DL3013
67
RUN pip install django --no-cache-dir
78

89
ENTRYPOINT ["python", "manage.py", "runserver", "0.0.0.0:80"]
9-

test-tools/wamr-ide/WASM-Debug-Server/Docker/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ WORKDIR /root/
88
COPY resource /root/
99

1010
## - download cmake with wget and set up
11+
# hadolint ignore=DL3008
1112
RUN wget --progress=dot:giga https://github.com/Kitware/CMake/releases/download/v3.21.1/cmake-3.21.1-linux-x86_64.tar.gz \
1213
&& tar -zxvf cmake-3.21.1-linux-x86_64.tar.gz \
1314
&& rm -f cmake-3.21.1-linux-x86_64.tar.gz \

test-tools/wamr-ide/WASM-Toolchain/Docker/Dockerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ WORKDIR /root/
1010
COPY resource /root/
1111

1212
## - download cmake with wget and set up
13+
# hadolint ignore=DL3008
1314
RUN wget --progress=dot:giga https://github.com/Kitware/CMake/releases/download/v3.21.1/cmake-3.21.1-linux-x86_64.tar.gz \
1415
&& tar -zxvf cmake-3.21.1-linux-x86_64.tar.gz \
1516
&& rm -f cmake-3.21.1-linux-x86_64.tar.gz \
@@ -66,6 +67,7 @@ COPY --from=BASE /root/build_wasm.sh ${HOME_DIR}
6667
RUN ln -s /opt/cmake/bin/cmake /usr/bin/cmake \
6768
&& ln -s ${HOME_DIR}/wamrc /usr/bin/wamrc
6869

70+
# hadolint ignore=DL3008
6971
RUN apt-get update && apt-get install -y make --no-install-recommends \
7072
&& apt-get clean -y \
7173
&& rm -rf /var/lib/apt/lists/*

0 commit comments

Comments
 (0)