Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should new devices be given 9-octet IDs by default? #1384

Open
marcosscriven opened this issue Jan 26, 2023 · 2 comments
Open

Should new devices be given 9-octet IDs by default? #1384

marcosscriven opened this issue Jan 26, 2023 · 2 comments

Comments

@marcosscriven
Copy link

Thanks for your efforts on this project - really nice to be able to integrate with Alexa without fiddling with adding skills.

It took me a while to get this going with a simple test http device - eventually it seems the device ID has to:

  1. Have no hyphen in (see Link Button? #1272 (comment))
  2. Have 9 octets (see Amazon Echo still not recognize 5.4.0 #1270 (comment))

Mine was of the form nn:nn:nn:nn:nn:nn:nn-nn. Initially I just tried changing the hyphen to a colon, but still no devices discovered , despite ./api/devices looking fine, and seeing all the expected UPnP trace logs.

I'm happy to update the wiki /trouble shooting (at the very least) to mention this, so people don't get too frustrated.

I'd also be interested in fixing the code to just generate the right form to start with - but only if you agree that's as expected?

@marcosscriven
Copy link
Author

Digging in I see @crush157's commit adding this as an option 7f72b03

However, I don't see any discussion or background on the PR.

Should this now be set to true by default?

@guy1958
Copy link

guy1958 commented Jan 30, 2023

Yes, I'd check that box by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants