You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @jlongster. Seems like a good suggestion. Since this is a backwards incompatible change- I'm going to consider this for the upcoming v5 release. (I kind of doubt anyone's using the library as window["react-virtualized"] but... just in case, I don't want to break them in a minor point release.)
I've actually been considering support Common JS only for the upcoming release. Although I guess I could also include a <script>-friendly dist file as well.
PS. Perfect timing on your Twitter post about hidden messages with script tags. I was just briefly thrown by the seemingly cutoff email summary I got for this issue.
Line https://github.com/bvaughn/react-virtualized/blob/master/webpack.config.dist.js#L14 in webpack makes it so that if you include this as a
<script>
tag on a page, it sets it towindow["react-virtualized"]
which is strange. I would expect it to bewindow.ReactVirtualized
, so that it exposes aReactVirtualized
global without forcing a referencing through the window object.The text was updated successfully, but these errors were encountered: