Skip to content
This repository has been archived by the owner on Jun 16, 2024. It is now read-only.

Final upgrades to editing UI #20

Open
4 of 7 tasks
perry-mitchell opened this issue Apr 28, 2019 · 10 comments
Open
4 of 7 tasks

Final upgrades to editing UI #20

perry-mitchell opened this issue Apr 28, 2019 · 10 comments
Assignees
Milestone

Comments

@perry-mitchell
Copy link
Member

perry-mitchell commented Apr 28, 2019

  • New group
  • Delete group
  • Rename group
  • Move group
  • Empty trash
  • Fix trash count (all entries and groups)
  • Show groups in trash
@zoheirkhonyagar
Copy link

@sallar @perry-mitchell
Can I work on remaining list of this issue ?

@sallar
Copy link
Member

sallar commented Dec 27, 2019

@zoheirkhonyagar Sure, why not? :)

@zoheirkhonyagar
Copy link

zoheirkhonyagar commented Dec 28, 2019

@sallar Thank you :)

@perry-mitchell
Copy link
Member Author

I've picked up the Rename-group feature myself, FYI.

@zoheirkhonyagar
Copy link

zoheirkhonyagar commented Jan 15, 2020

@sallar @perry-mitchell Where is the empty trash button position in the component ? I suggest when user right click on Trash button, open a menu and show "Empty Trash" option something like this image that I've attached.

Screenshot from 2020-01-16 01-12-11

@zoheirkhonyagar
Copy link

zoheirkhonyagar commented Jan 15, 2020

I see it now that @perry-mitchell is working on this issue in groups_menu branch . if there are tasks that you didn't start working on, I can do them :)

@perry-mitchell
Copy link
Member Author

@zoheirkhonyagar Ive decided that I won’t attempt to do the empty trash etc in this branch as that’s big enough on its own.

We need to display a tree of contents for the trash as it also holds groups, not just entries. Maybe, as @sallar suggested to me, it could be clicked which would slide up and reveal the trash tree instead of the regular one. There’s a helper function called emptyTrash in the useGroups hook.

@zoheirkhonyagar
Copy link

@perry-mitchell Thank you for your explanation,I got that . so can I work on empty trash now ?

@zoheirkhonyagar
Copy link

so I've picked up the Empty trash feature, FYI.

@zoheirkhonyagar
Copy link

zoheirkhonyagar commented Jan 25, 2020

@perry-mitchell Hey, I tried to understand project structure but it's hard for me because I'm new in React, I define onEmptyTrash function in EntriesList.js and then add onClick event to PaneContent, In onEmptyTrash I call emptyTrash helper that you mentioned. but when it calls pane title changes to Document. I'm confused 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants