Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal output cleared with multiple tabs [BR] #135

Closed
2 of 4 tasks
ywanHK opened this issue Aug 2, 2020 · 9 comments · Fixed by #136
Closed
2 of 4 tasks

Terminal output cleared with multiple tabs [BR] #135

ywanHK opened this issue Aug 2, 2020 · 9 comments · Fixed by #136
Labels
bug report 🐛 When something isn't working released 📮 Release has been made

Comments

@ywanHK
Copy link

ywanHK commented Aug 2, 2020

  • I have reset Atom to defaults prior to submitting report.
  • I have not reset Atom to defaults prior to submitting report.
  • I have tried uninstalling/reinstalling the terminal.
  • I have not tried uninstalling/reinstalling the terminal.

Description

When opening multiple tabs in the same position (i.e. right dock), output of all other tabs will be cleared automatically

Steps to reproduce

  1. Open terminal in the right dock
  2. Type in any command to get some output on the screen
  3. Open another terminal tab in the right dock
  4. Output from the first terminal is cleared

Expected behavior:

Output from all non-active tabs should remain unaffected when a new terminal is opened in the same location
Output from tab should not be affected when unfocused.

Actual behavior:

The output is cleared when a new tab is opened in the same location or when a tab is unfocused (demonstrated by the following 2 videos)
https://www.youtube.com/watch?v=Wpq_OmmHr4w
https://www.youtube.com/watch?v=3KLlx4Vk5JQ

Reproduces how often:

Always

Versions

> atom --version
Atom    : 1.45.0
Electron: 4.2.7
Chrome  : 69.0.3497.128
Node    : 10.11.0
> apm --version
apm  2.4.3
npm  6.2.0
node 10.2.1 x64
atom 1.45.0
python 3.7.1
git 2.25.0
visual studio 2015

OS name and version: Windows 10 x64
Terminal version: 9.0.3

Additional context

@ywanHK ywanHK added the bug report 🐛 Something isn't working label Aug 2, 2020
@UziTech UziTech added bug report 🐛 When something isn't working unable to duplicate !! When the issue cannot be duplicated and removed bug report 🐛 Something isn't working labels Aug 3, 2020
@UziTech
Copy link
Member

UziTech commented Aug 3, 2020

I am not able to reproduce this. I am on Windows 10 and it does not clear the output for my console.

x-terminal-clear

@ywanHK
Copy link
Author

ywanHK commented Aug 3, 2020

That's weird, I tried with different versions of Atom (Portable Version) from 1.45.0 to 1.50.0-beta and it all turned out the same

Can you specify what version of Atom and apm are you using?

BTW, I haven't seen this issue on my machine with version 9.0.0 or earlier, I upgraded the package from 9.0.0 yesterday and ran into this.

@the-j0k3r
Copy link
Member

the-j0k3r commented Aug 3, 2020

(Portable Version)

I wonder what the differences are. and if something is interfering

I upgraded the package from 9.0.0 yesterday and ran into this.

The resizing code that was merged which was biggest change in relation to 9.x.x I dont think that would affect this. Bt who knows.

@ywanHK
Copy link
Author

ywanHK commented Aug 3, 2020

Ok I have tried package versions

  • 9.0.0
  • 9.0.1
  • 9.0.2
  • 9.0.3

It seems like the problem only exists in 9.0.3 which I believe is the latest version

I have tried to install atom 1.49.0 with both the Installer and the Zip file but the problem persists.
So I don't think it's a problem with the atom installation.

I have also tried removing python and msys2 from the path before installing the package. But after installing package the problem is still there, so I guess the building process is OK.

@ywanHK
Copy link
Author

ywanHK commented Aug 3, 2020

x-terminal-clear

I noticed that your CMD version is 10.1.19042.421 while mine is 10.0.18362.959

@UziTech
Copy link
Member

UziTech commented Aug 3, 2020

It seems the issue is in PR #129 I also removed element-resize-detector and changed it to use ResizeObserver.

I'm testing it out a bit more but I can reproduce it now.

@UziTech UziTech removed the unable to duplicate !! When the issue cannot be duplicated label Aug 3, 2020
@UziTech
Copy link
Member

UziTech commented Aug 3, 2020

This should be fixed by #136 and released shortly. Thanks for reporting it 🎉

@ywanHK
Copy link
Author

ywanHK commented Aug 5, 2020

I'm guessing that it's fixed by now?

@github-actions
Copy link

github-actions bot commented Aug 5, 2020

🎉 This issue has been resolved in version 9.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released 📮 Release has been made label Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report 🐛 When something isn't working released 📮 Release has been made
Development

Successfully merging a pull request may close this issue.

3 participants