[BR] X-terminal does not change its dimensions by changing the panes dimension

[aminya]

• [] I have reset Atom to defaults prior to submitting report.
• I have not reset Atom to defaults prior to submitting report.
• I have tried uninstalling/reinstalling the terminal.
• I have not tried uninstalling/reinstalling the terminal.

Description

X-terminal does not change its dimensions by changing the panes dimension

Steps to reproduce

1. Open a terminal and put in the bottom pane (besides) linter.
2. Resize so it's big.
3. type enter a couple of times so it gets filled.
4. now make the pane smaller
5. x-terminal does not resize like how Windows terminal resizes
   You can do this the other way around. Start with small and then make it bigger. The content does not go into the now empty black part.

Expected behavior:
Resizabliltiy like Windows terminal

Actual behavior:

I expect my pointer to be the last line, and I should not have to scroll for seeing it.

Reproduces how often:
Always

Versions

❯ atom -v

Atom    : 1.49.0       
Electron: 5.0.13       
Chrome  : 73.0.3683.121
Node    : 12.0.0       

❯ apm -v
apm  2.5.0
npm  6.14.5
node 10.20.1 x64    
atom 1.49.0
python 3.8.5        
git 2.27.0.windows.1
visual studio 2015  

OS name and version: Win 10
Terminal version: 8.2.3

Additional context

[UziTech]

This is a known issue in xterm.js

[UziTech]

Maybe it changes based on the terminal but I think Powershell 7 works the way it is supposed to:

[UziTech]

or are you referring to horizontal resizing?

it seems to work well for the current line:

but this is what I meant is a known issue in xterm. There are only a certain number of lines they re-render on resize:

[UziTech]

I wouldn't really consider this a bug but just a limitation of the software.

[aminya]

I usually use the terminal either on the right side or on the bottom depending on the work.

Yes, the side resizing does not work always.

The bottom resizing works sometimes, but not always. I can run clear once in a while to bring the cursor at the top. Maybe there is a command to bring it to the top without clearing (!?). Like this: https://github.com/JunoLab/atom-ink/blob/e151e3d629bce5f0235505a91fdd1ed2895d0ca9/lib/console/console.js#L290

[UziTech]

So your problem is that x-terminal doesn't move the text up when the cursor goes below the bottom of the screen?

Can you share your x-terminal configuration and your powershell configuration?

[aminya]

So your problem is that x-terminal doesn't move the text up when the cursor goes below the bottom of the screen?

Can you share your x-terminal configuration and your powershell configuration?

Most of the things for x-terminal are on default

For PowerShell I use a couple of fancy things like fonts or git status here and there, but those do not affect the terminal itself.

[UziTech]

do you have anything in "xterm.js Terminal Options" setting?

[aminya]

No. Everything is default:

[UziTech]

I think I figured out what is happening. We call refitTerminal whenever the terminal is resized but when dragging to a different dock x-terminal thought the terminal was hidden so it wouldn't refit.

In #129 I removed the observer after it is initially visible so it stops marking it as invisible.

If you could, try the code from that PR and see if it fixes your issue.

[github-actions]

🎉 This issue has been resolved in version 9.0.3 🎉

The release is available on:

• GitHub release
• Atom package

Your semantic-release bot 📦🚀