Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The config-options.build2 arrangement will stop working in build2 0.15.0 #2

Closed
boris-kolpackov opened this issue Jul 22, 2022 · 3 comments

Comments

@boris-kolpackov
Copy link

This package shares config directives between the library and tests by factoring them into the common config-options.build2 file. This will stop working without extra arrangements once 0.15.0 is released. For background and what those extra arrangements would be, see: https://build2.org/stage/bpkg/doc/build2-package-manager-manual.xhtml#package-skeleton

However, in this particular case, the better solution is to not have configuration in the tests at all and instead convey it from the library using metadata, as described here: https://github.com/build2/HOWTO/blob/master/entries/convey-additional-information-with-exe-lib.md

@Klaim
Copy link
Collaborator

Klaim commented Jul 22, 2022

Thanks for reminding me, I intend to fix this while working on v9.0.0. I suppose I should also revise the other published versions that used the config options.

@boris-kolpackov
Copy link
Author

I suppose I should also revise the other published versions that used the config options.

I don't think this is urgent: the existing package archives will still work as long as nobody tries to configure them as dependencies. Which I think is highly unlikely to happen in this case (the only configuration variable it has is to enable modules support which I don't believe works correctly).

@kamrann kamrann mentioned this issue Aug 10, 2022
@Klaim Klaim closed this as completed in bef2ed5 Dec 10, 2022
@Klaim
Copy link
Collaborator

Klaim commented Dec 10, 2022

Looks like this was closed automatically, but the merged PR didn't fix that.

This issue should be fixed (following @boris-kolpackov 's recommendations) by bef2ed5 and 56c3e8d .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants