feat(rust): add dyn_info for dynamic output with `ockam node create…
#3223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…|show` and others
lameferret
force-pushed
the
dynamicinfo
branch
2 times, most recently
from
5c7f4a4 to
cb16dd2
Compare
lameferret
force-pushed
the
dynamicinfo
branch
from
cb16dd2 to
b61e1d0
Compare
Contributor
|
The related issue was already merged some time ago with this PR #3504 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP Fix #3177
This is really rough, improvements I can think of:- have enums forTypeandAddressbeing dependent on it.- useString::with_capacity()to reduce reallocations.- add more options (if any)\tand\n?serivceintoservice_briefandservice_verbose, to reduceNoneusage?I'm sure there are many more improvements that can be made, please provide your recommendations.