Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native doesn't support unhandled Promise rejections from Bluebird #1447

Open
jeremy303 opened this issue Jun 24, 2021 · 1 comment
Open
Labels
backlog We hope to fix this feature/bug in the future feature request Request for a new feature

Comments

@jeremy303
Copy link

Describe the bug

If a React Native app uses Bluebird for promises, Bugsnag will not report unhandled promise rejections.

Filing this as a bug rather than a feature request as looking at the changelog suggests Bluebird promises are supported, however support has only been implemented in the browser. Bluebird support was never added to plugin-react-native-unhandled-rejection-- although adding it seems very straightforward.

Using the existing Bugsnag code as an example, I've now implemented my own global unhandled rejection handler within my app and am manually creating Bugsnag events, which should hold us over until proper Bluebird support can be added for React Native. Unfortunately, I don't have time at the moment to ensure that this handles all edge cases and is sufficiently robust to commit back to the repo.

Steps to reproduce

  1. Configure Bluebird as the global Promise implementation and Bugsnag to report unhandled Promise rejections.
  2. Generate an unhandled Promise rejection.
  3. Observe that it is not reported to Bugsnag.

Environment

React Native
bugsnag-js 7.9.5

@johnkiely1
Copy link
Member

Hey @HolySamosa,

As discussed in the email chain, but for the benefit of the wider community, we will be looking to add this support for React Native when we can. I don't have any estimate on timeframe as yet but I will post here with any updates on this.

@johnkiely1 johnkiely1 added backlog We hope to fix this feature/bug in the future feature request Request for a new feature labels Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We hope to fix this feature/bug in the future feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants