Update target frameworks #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Update target frameworks to
net462andnetstandard2.0and dropnet35,net40andnetstandard1.3.Design
The minimum target framework for .NET Framework is now
net462- this is the earliest version still in support, and seems to be the current baseline for .NET Framework support in other libraries.The
netstandard1.3target has been removed altogether, as per Microsoft's guidelines on cross-platform targeting.Some preprocessor directives have also been removed/updated to match the new target frameworks.
Also temporarily disabled nuget package vulnerability warnings to allow the restore to succeed and get the build and tests passing again. This will be reverted later as part of a separate task to update dependencies.
Testing
Maze Runner no longer seems to be working in CI/AppVeyor, so maze runner tests have been temporarily disabled.