Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOM reporting doesn't consider device reboots #545

Closed
jparise opened this issue Apr 16, 2020 · 2 comments
Closed

OOM reporting doesn't consider device reboots #545

jparise opened this issue Apr 16, 2020 · 2 comments
Labels
feature request Request for a new feature released This feature/bug fix has been released

Comments

@jparise
Copy link

jparise commented Apr 16, 2020

Description

computeDidOOMLastLaunchWithConfig: uses a number of heuristics to determine whether or not the last launch terminated due to an OOM condition.

One input that's not considered is the device's boot time, which can be used to determine whether or not the device was rebooted. (Reboots don't send an explicit termination signal to apps so this case could be classified as an OOM.)

Describe the solution you'd like

Compare the current launch's boot time to the last launch's boot time.

time_t systemBootTime = 0;
struct timeval boottime;
size_t size = sizeof(boottime);
if (sysctlbyname("kern.boottime", &boottime, &size, NULL, 0) != -1) {
    systemBootTime = boottime.tv_sec;
}
@abigailbramble abigailbramble added the feature request Request for a new feature label Apr 23, 2020
@abigailbramble
Copy link

Hi @jparise thanks for the report! Improvements to our OOM detection heuristic is on our roadmap and we hope to improve this in a future release. We will be working on this when priorities allow.

@johnkiely1
Copy link
Member

Hi @jparise

We have now made OOM detection improvements in v6.2.5 which considers whether the device was rebooted or not.

Thanks again for suggesting this.

@johnkiely1 johnkiely1 added released This feature/bug fix has been released and removed backlog We hope to fix this feature/bug in the future labels Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature released This feature/bug fix has been released
Projects
None yet
Development

No branches or pull requests

3 participants