Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default tech notes has bad path for cookie graphic #247

Open
davewhiteland opened this issue May 23, 2024 · 0 comments
Open

default tech notes has bad path for cookie graphic #247

davewhiteland opened this issue May 23, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@davewhiteland
Copy link
Collaborator

davewhiteland commented May 23, 2024

Needs leading slash on /assets/img/cookie.png?

https://github.com/buggyrace/buggy-race-server/blob/main/tech_notes/content/tech-notes/secret-key.md?plain=1#L77-L79

https://demo.buggyrace.net/tech-notes/secret-key#login-example

Screenshot 2024-05-24 at 00 26 34

[Not editing any tech notes while RHUL CS1998 teaching term is still running, to avoid conflicts with the custom tech notes. (Maybe github modules handle this better, but there is a strong case for doing custom tech notes in a different dir, and changing the config settings _TECH_NOTES_* which already exist... maybe expose those as editable config precisely for this scenario.

The exciting cookie should look like this :
https://demo.buggyrace.net/assets/img/cookie.png

@davewhiteland davewhiteland added bug Something isn't working enhancement New feature or request labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant