fix(reload): ensure daemon starts, even if reload not required #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I found the cause of #28
Problem:
Calling
daemon.Reload()
within thesync
handler is the only place that theonionbalance
service gets launched. The handler only calls "daemon.Reload()" when the configuration file (/run/onionbalance/config.yaml
) doesn't exist yet or has changed.On a fully clean start, this file doesn't exist yet, so the daemon does get started correctly. However, if the container restarts within the pod (but the pod itself isn't re-created), the
config.yaml
already exists, and so the daemon does not get started.Solution:
This PR fixes this by adding an additional method "EnsureRunning()" which will start the daemon if it's not already running.
I also added small changes for:
SIGHUP
, but never called start again.Other considerations:
I noticed that the standard
tor
service (/agents/tor/local
) also has similar logic around reload/start, so there may be a similar issue there that would be worth investigating.Let me know if there are any changes/improvements I can add to his PR.