Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't load entire request file into memory #52

Closed
dcarley opened this issue Oct 25, 2013 · 1 comment
Closed

Don't load entire request file into memory #52

dcarley opened this issue Oct 25, 2013 · 1 comment
Labels
enhancement New feature or feature request

Comments

@dcarley
Copy link
Collaborator

dcarley commented Oct 25, 2013

When reading a dump of requests the entire file shouldn't be loaded into memory and parsed in one go. Instead it should iterate over chunks, presumably starting the replay process as soon as possible.

Raised in #48 (although no change to existing behaviour).
@buger
Copy link
Owner

buger commented Oct 29, 2013

Fixed in #46.

It was really easy to do using gob.Decoder : https://github.com/buger/gor/blob/95d3676d837f6606c73af1e6b48ac47b088080ea/input_file.go

@buger buger closed this as completed Oct 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@buger @dcarley