Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing selftests on nightly 1.24 windows MSVC builds. #72

Closed
budziq opened this issue Dec 25, 2017 · 3 comments
Closed

Failing selftests on nightly 1.24 windows MSVC builds. #72

budziq opened this issue Dec 25, 2017 · 3 comments

Comments

@budziq
Copy link
Owner

budziq commented Dec 25, 2017

Skeptic fails self tests with recent nightly (1.24) on windows MSVC builds as it cannot find / link with serde_derive (which is typically so/dll as opposed to rlib).

Link to appveyor

error[E0463]: can't find crate for `serde_derive` which `skeptic` depends on
 --> C:\Users\appveyor\AppData\Local\Temp\1\rust-skeptic.xTHyFOhM2mC8\test.rs:2:1
  |
2 | extern crate skeptic;
  | ^^^^^^^^^^^^^^^^^^^^^ can't find crate
error: aborting due to previous error
test readme_sect_getting_started_line_34 ... FAILED
test hashtag_test_line_45 ... ok
test readme_sect_getting_started_line_67 ... ignored
error[E0463]: can't find crate for `serde_derive` which `skeptic` depends on
 --> C:\Users\appveyor\AppData\Local\Temp\1\rust-skeptic.0ndspglQlDPV\test.rs:2:1
  |
2 | extern crate skeptic;
  | ^^^^^^^^^^^^^^^^^^^^^ can't find crate
error: aborting due to previous error
test readme_sect_getting_started_line_49 ... FAILED
@Ryman
Copy link
Contributor

Ryman commented Dec 30, 2017

I'm unable to reproduce this on my Windows 7 64bit machine with either the nightly listed in the log from my PR nightly-2017-12-24-x86_64-pc-windows-msvc ~ rustc 1.24.0-nightly (169929308 2017-12-23) or the latest nightly rustc 1.24.0-nightly (2dad872a2 2017-12-29). There doesn't seem to be anything special required to install listed in the appveyor setup so I'm unsure if I'm missing a step or not, I'm just cleaning, building and testing.

@budziq
Copy link
Owner Author

budziq commented Dec 31, 2017

Thanks for looking into this. The problem should be reproducible by just

git clone https://github.com/budziq/rust-skeptic.git
cd rust-skeptic
cargo test

Even on latest rustc 1.24.0-nightly (3f916bd30 2017-12-30)
Historically Win 7 behaved differently (had less problems) than Win 10 which is used by appveyor build. I guess that this is another case where the differences surface. I'll not have access to a windows 10 box for the upcoming few days (and debugging via appveyor is less than ergonomic).

@budziq
Copy link
Owner Author

budziq commented May 15, 2018

looks like the problem is nonexistent on latest 0.13.3 with rust 1.26

@budziq budziq closed this as completed May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants