Rebuild of DBD::Pg is failing with GCC 15

[jplesnik]

The regular rebuild of perl-DBD-Pg failed in Fedora Rawhide(42).
The reason of the failure seems to be GCC 15 which is part of latest Fedora.

types.c:18:98: error: initialization of ‘char * (*)(void)’ from incompatible pointer type ‘char * (*)(PerlInterpreter *, const char *, STRLEN,  STRLEN *, int)’ {aka ‘char * (*)(struct interpreter *, const char *, long unsigned int,  long unsigned int *, int)’} [-Wincompatible-pointer-types]
   18 |  {PG_ACLITEMARRAY                  ,"_aclitem"                     ,1,',',"array_out"           ,quote_string,dequote_string,{0},0},
      |                                                                                                  ^~~~~~~~~~~~
types.c:18:98: note: (near initialization for ‘pg_types[0].quote’)
In file included from Pg.h:68,
                 from types.c:15:
quote.h:3:8: note: ‘quote_string’ declared here
    3 | char * quote_string(pTHX_ const char *string, STRLEN len, STRLEN *retlen, int estring);
      |        ^~~~~~~~~~~~

The complete build log is attached to the bugzilla:
https://bugzilla.redhat.com/show_bug.cgi?id=2341025

[esabol]

That's just the tip of the iceberg. Many (perhaps all?) of the quote and dequote functions in that table give similar incompatible pointer errors from what I can see.

Also, the build log at the above URL is actually incomplete, as it is truncated to the last 32k, so there could be other errors?

[jplesnik]

There you can find out the complete log.

https://koji.fedoraproject.org/koji/taskinfo?taskID=128501349

[michal-josef-spacek]

Actual build logs are in https://koschei.fedoraproject.org/package/perl-DBD-Pg?

[michal-josef-spacek]

Provisional fix is use -std=gnu17, see https://src.fedoraproject.org/rpms/perl-DBD-Pg/pull-request/3