Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescan progress notifications may be handled after rescan finishes. #99

Closed
jrick opened this issue Jun 16, 2014 · 1 comment
Closed

Comments

@jrick
Copy link
Member

jrick commented Jun 16, 2014

Because rescan notifications are "buffered" with the rest of notification processing (especially with recvtx and redeemingtx), they may be handled by the rescan manager after a rescan has finished (after the rescan RPC returns). There needs to be some synchronization between these notifications for the rescan manager so that progress notifications are not handled before the rescan finished notification, and so wallets will not be marked partially synced even after a rescan completed successfully.

@jrick jrick self-assigned this Jun 16, 2014
@jrick
Copy link
Member Author

jrick commented Jun 16, 2014

A large part of this issue is how btcd processes notifications. Notifications are queued up and sent asynchronously from the code which created the notifiation, which means there is no guarantee that a rescanprogress notification will be sent before the rescan RPC returns.

The best and easiest solution here would probably be to signal a finished rescan from a new notification, rather than based on the rescan RPC returning.

@jrick jrick added bug labels Jun 16, 2014
@jrick jrick closed this as completed in aa6892a Jun 16, 2014
@jrick jrick removed their assignment Jan 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant