Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: undefined method named getConfiguration() #139

Closed
1 task done
ndeet opened this issue Jul 3, 2024 · 3 comments · Fixed by #140
Closed
1 task done

[Bug]: undefined method named getConfiguration() #139

ndeet opened this issue Jul 3, 2024 · 3 comments · Fixed by #140
Assignees
Labels
bug Something isn't working

Comments

@ndeet
Copy link
Contributor

ndeet commented Jul 3, 2024

What is your BTCPay Server version?

unknown

How did you deploy BTCPay Server?

unknown

What is version of the PrestaShop plugin are you using?

BTCPay plugin v6.1.4
PrestaShop v8.0.4

What happened?

A user reported that there is an error of "undefined method named 'getConfiguration()' of class BTCPay\Controller\Admin\Improve\Payment\ConfigureController when clicking on "configure" after installing the plugin.

How did you encounter this bug?

  1. Install the plugin
  2. click "configure"
  3. error

image

Relevant log output

see above

What browser do you use (if useful)?

No response

Additional information

No response

Are you sure this is a bug report?

  • I confirm this is a bug report
@ndeet ndeet added the bug Something isn't working label Jul 3, 2024
@ndeet
Copy link
Contributor Author

ndeet commented Jul 3, 2024

I think the problem is because 8.0.x did not have that function and it was introduced in 8.1.0, see https://github.com/PrestaShop/PrestaShop/blob/8.0.x/src/PrestaShopBundle/Controller/Admin/FrameworkBundleAdminController.php

@BitcoinMitchell can you do a version constraint for the plugin so it does not install with 8.0.x or do a workaround via a version check by calling FrameworkBundleAdminController::configuration in case of 8.0.4 and getConfiguration() on newer versions?

@ndeet
Copy link
Contributor Author

ndeet commented Jul 3, 2024

@BitcoinMitchell
Copy link
Collaborator

There is a framework restraint as defined in https://github.com/btcpayserver/prestashop-plugin/blob/6.x/modules/btcpay/src/Constants.php#L15

Didn't notice that this was a new 8.1.0 change, will release a fix when I have time later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants