-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code in header produce invalid anchor #105
Comments
@cup, thanks for checking in on this. I'm assuming that those Are you using an older version of AnchorJS? Perhaps it's only happening in a specific browser? It would be 👌 if you could show me a example of the issue. |
@bryanbraun uh yeah simple |
Cool thanks. It looks like AnchorJS isn't generating those IDs. If I disable Javascript in my browser and load the page it still says (by default, AnchorJS only generates IDs if the element doesn't already have an ID) I saw that you already created an issue at github/jekyll-commonmark-ghpages#10, so I'm thinking about closing this one. For what it's worth, you may be able to tweak your markdown settings to disable ID generation, or switch to a different markdown parser to work around the issue. |
@bryanbraun yes i agree with you on all fronts - it seems the issue is that https://jekyllrb.com/docs/configuration/markdown sadly KramDown has its own problems: so it seems like the best option currently is to just stick with |
The Jasmine update caused our tests to run in random order by default, which resulted in occasionally failing tests. By making some adjustments to the tests, we were able to get them passing consistantly.
If you use some markup like this:
I would expect this result:
however what is generated is:
The text was updated successfully, but these errors were encountered: