Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] Windows: Waiting for Firefox to connect ... #501

Closed
Dragon1573 opened this issue Dec 20, 2023 · 6 comments
Closed

[Bug report] Windows: Waiting for Firefox to connect ... #501

Dragon1573 opened this issue Dec 20, 2023 · 6 comments

Comments

@Dragon1573
Copy link
Contributor

Related issues

Description

During manually validation in Windows Sandbox, browsh.exe cannot launch Mozilla.Firefox (installed via winget.exe). I think this behaviour is not expected.

image

Logs

Looking in C:\Users\WDAGUtilityAccount\AppData\Roaming\browsh\config.toml for config.
Attempting to connect to Firefox Marionette
Starting Firefox in headless mode
Windows registry Firefox version: 120.0.1
Using Firefox at: C:\Program Files\Mozilla Firefox\firefox.exe
Windows registry Firefox version: 120.0.1
Using default profile at: C:\Users\WDAGUtilityAccount\AppData\Roaming\browsh\firefox_profile
Sending `WebDriver:NewSession` to Firefox Marionette
Sending `Addon:Install` to Firefox Marionette
Starting Browsh CLI client
Starting websocket server...
FF-MRNT: 50:{"applicationType":"gecko","marionetteProtocol":3}
Webextension not connected. Message not sent: /tty_size,146,42
FF-MRNT: 1106:[1,1,{"error":"unknown error","message":"Expected absolute path: [Exception... \"Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIFile.initWithPath]\"  nsresult: \"0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)\"  location: \"JS frame :: chrome://remote/content/marionette/addon.sys.mjs :: install :: line 70\"  data: no]","stacktrace":"RemoteError@chrome://remote/content/shared/RemoteError.sys.mjs:8:8\nWebDriverError@chrome://remote/content/shared/webdriver/Errors.sys.mjs:189:5\nUnknownError@chrome://remote/content/shared/webdriver/Errors.sys.mjs:768:5\ninstall@chrome://remote/content/marionette/addon.sys.mjs:72:13\nGeckoDriver.prototype.installAddon@chrome://remote/content/marionette/driver.sys.mjs:2953:21\ndespatch@chrome://remote/content/marionette/server.sys.mjs:318:40\nexecute@chrome://remote/content/marionette/server.sys.mjs:289:16\nonPacket/<@chrome://remote/content/marionette/server.sys.mjs:262:20\nonPacket@chrome://remote/content/marionette/server.sys.mjs:263:9\n_onJSONObjectReady/<@chrome://remote/content/marionette/transport.sys.mjs:494:20\n"},null]
Webextension not connected. Message not sent: /tty_size,146,42
FF-CONSOLE: [GFX1-]: RenderCompositorSWGL failed mapping default framebuffer, no dt
FF-MRNT: 683:[1,0,null,{"sessionId":"435a1a28-ae7e-43cd-92dc-4dd8d2b023c6","capabilities":{"browserName":"firefox","browserVersion":"120.0.1","platformName":"windows","acceptInsecureCerts":false,"pageLoadStrategy":"normal","setWindowRect":true,"timeouts":{"implicit":0,"pageLoad":300000,"script":30000},"strictFileInteractability":false,"unhandledPromptBehavior":"dismiss and notify","moz:accessibilityChecks":false,"moz:buildID":"20231129155202","moz:headless":true,"moz:platformVersion":"10.0","moz:processID":1912,"moz:profile":"C:\\Users\\WDAGUtilityAccount\\AppData\\Roaming\\browsh\\firefox_profile","moz:shutdownTimeout":60000,"moz:webdriverClick":true,"moz:windowless":false,"proxy":{}}}]
Sending `Marionette:Quit` to Firefox Marionette
*errors.errorString normal
/home/runner/work/browsh/browsh/interfacer/src/browsh/tty.go:113 (0x4d283d)
/home/runner/work/browsh/browsh/interfacer/src/browsh/firefox.go:311 (0x4ca8c5)
/opt/hostedtoolcache/go/1.18.10/x64/src/runtime/asm_amd64.s:1571 (0x1e31c1)

Environments

  • Windows 11 Professional 23H2 (22635.2915)
  • Windows Feature Experience Pack 1000.22682.1000.0
  • Windows Sandbox
    • Windows 11 Enterprise 22H2 (22621.2915)
    • Windows Package Manager v1.6.3482
      • Mozilla Firefox (x64 en-US) 120.0.1
      • Browsh 1.8.2
@tombh
Copy link
Member

tombh commented Dec 20, 2023

In microsoft/winget-pkgs#104234, you had some suggestions for changes? Would you like to make a PR so others can test it?

@Dragon1573
Copy link
Contributor Author

Okay, I'll try if it can help. 😄

@Dragon1573
Copy link
Contributor Author

The pull request is successfully merged, but I failed to build the executable on my own.

Will validate the patch manually later. 😄

@Dragon1573
Copy link
Contributor Author

Tools/SandboxTest.ps1 is currently unavailable because there's an error in the script file. Moderators of microsoft/winget-pkgs are currently working on it.

Just create a pull request without verify the manifest locally. If it can pass the installation, then #502 is proved to be a valid patch.

@Dragon1573
Copy link
Contributor Author

Microsoft Azure Pipelines of that pull request is successfully passed. This is a valid fix ❤️

@tombh
Copy link
Member

tombh commented Jan 29, 2024

Awesome! I'll make a new release then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants