-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable color/monochrome mode from CLI and config file #187
Comments
I might be able to take a look at this this weekend. For the second point, are you thinking a flag --monochrome or something? |
@j-rewerts If you implement a --monochrome flag, then you should also implement a --truecolor flag, because someone might want to change the default in the configuration file to monochrome and use true color mode occasionally using the --truecolor flag. |
That seems like a good approach. We do already use |
@j-rewerts |
I hadn't thought about the mutual exclusivity. Good point! |
@j-rewerts @tombh deliberately uses British English, and therefore writes color as colour. Usually American English is used on the command line. But British spelling is used all throughout this project, so maybe we should stick to it. Personally I'd prefer color, because it's shorter. Maybe we can be one of few software projects to support both spellings on the command line. |
Haha, I think 'color' is better for user-facing features, but 'colour' has already become the standard in the code base, just because why not :D So I think the CLI should be |
@tombh |
@CodyGramlich I know you're interested in taking this one. Feel free to take it over! |
Great. We'll work on it right now! |
@j-rewerts @CodyGramlich |
This is a job for a junior browsh developer and should be possible to solve for anyone who has the development environment setup.
Currently the monochrome mode can only be activated by pressing ALT+m.
The default should be configurable in the config.
And it should be possible to select the color mode from the command line.
Use cases:
The text was updated successfully, but these errors were encountered: