Deep references no longer working

[matthewp]

#62 added the ability to reference modules deeply with "browser". It seems that functionality is no longer working. For example deep/ref will work but very/deep/ref will not.

I think the reason is this regular expression: https://github.com/substack/node-resolve/blob/master/lib/async.js#L109

I assume this is intended to chop off the back but instead is chopping off the front. /Users/matthew/foo becomes matthew/foo. I'll submit a new test and fix the regex.

[matthewp]

I'm unsure about the intent of this code. This is where the bug occurs:

dir.replace(/[\\\/]*[^\\\/]+[\\\/]*/, ''), cb

This will cause recursion like:

/Users/matthew/Projects/node-resolve/test/precedence/aaa
matthew/Projects/node-resolve/test/precedence/aaa
Projects/node-resolve/test/precedence/aaa

I would assume what you really want is:

/Users/matthew/Projects/node-resolve/test/precedence/aaa
/Users/matthew/Projects/node-resolve/test/precedence
/Users/matthew/Projects/node-resolve/test

But in that case why a regex and not path.dirname? That leads me to believe my assumption about what this code is trying to do might be wrong. I updated this regex with one that does what I think it should do but that breaks a couple of other tests. But I can't imagine the behavior that is currently happening is intentional.

Could you give some insight as to why you implemented it this way @substack?

[matthewp]

I've added a breaking test. Using a different regex or path.dirname will fix this issue but cause other tests to fail which seem to depend on this bug. I'm going to try and investigate what they are doing.

[matthewp]

Ok, after looking at the failing tests they were checking if a pkg was found (expecting it not to be) but I don't think this is a necessary part of the tests. The precedence test is verifying that precedence is given to folder/index.js and that is working. Submitting a PR.