Skip to content

Fixes for Node.js <= 0.12 and Firefox <66 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 1, 2019
Merged

Fixes for Node.js <= 0.12 and Firefox <66 #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1ef3b53
fix DataView on node 0.10
goto-bus-stop May 1, 2019
df78840
"polyfill" deepStrictEqual on Node 0.12 and below
goto-bus-stop May 1, 2019
9938769
tests run in child processes
goto-bus-stop May 1, 2019
8a7cde3
Skip fake typed array test in FF
goto-bus-stop May 1, 2019
36d50aa
Fix deepStrictEqual "polyfill"
goto-bus-stop May 1, 2019
3959376
Handle Node.js <= 0.12 Buffers not based on ArrayBuffer
goto-bus-stop May 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions support/types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,10 @@ function isUint8Array(value) {
} else {
return (
ObjectToString(value) === '[object Uint8Array]' ||
isBuffer(value)
// If it's a Buffer instance _and_ has a `.buffer` property,
// this is an ArrayBuffer based buffer; thus it's an Uint8Array
// (Old Node.js had a custom non-Uint8Array implementation)
isBuffer(value) && value.buffer !== undefined
);
}
}
Expand Down Expand Up @@ -309,7 +312,7 @@ function isDataViewToString(value) {
isDataViewToString.working = (
typeof ArrayBuffer !== 'undefined' &&
typeof DataView !== 'undefined' &&
isDataViewToString(new DataView(new ArrayBuffer()))
isDataViewToString(new DataView(new ArrayBuffer(1), 0, 1))
);
function isDataView(value) {
if (typeof DataView === 'undefined') {
Expand Down
27 changes: 20 additions & 7 deletions test/node/types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ var vm = require('vm');
var Buffer = require('safe-buffer').Buffer
var objectEntries = require('object.entries');

// "polyfill" deepStrictEqual on Node 0.12 and below
if (!assert.deepStrictEqual) {
assert.deepStrictEqual = assert.deepEqual;
}

function uncurryThis(f) {
return f.call.bind(f);
}
Expand Down Expand Up @@ -82,7 +87,7 @@ for (var _i = 0, _arr = [
value: 'foo'
});
}, 'isUint8Array'],
[function () { return new DataView(new ArrayBuffer(1)); }, 'isDataView'],
[function () { return new DataView(new ArrayBuffer(1), 0, 1); }, 'isDataView'],
[function () { return new SharedArrayBuffer(); }, 'isSharedArrayBuffer'],
// [ new Proxy({}, {}), 'isProxy' ],
[function () { return new WebAssembly.Module(wasmBuffer); }, 'isWebAssemblyCompiledModule']
Expand Down Expand Up @@ -137,7 +142,9 @@ console.log('Testing', 'isBoxedPrimitive');

var SymbolSupported = typeof Symbol !== 'undefined';
var SymbolToStringTagSupported = SymbolSupported && typeof Symbol.toStringTag !== 'undefined';
if (SymbolToStringTagSupported) {
var isBuggyFirefox = typeof navigator !== 'undefined' && /Firefox\/\d+/.test(navigator.userAgent) &&
parseInt(navigator.userAgent.split('Firefox/')[1], 10) < 66
if (SymbolToStringTagSupported && !isBuggyFirefox) {
[
'Uint8Array',
'Uint8ClampedArray',
Expand All @@ -164,13 +171,19 @@ if (SymbolToStringTagSupported) {
assert(types[method](array));
});
}
if (isBuggyFirefox) {
console.log('skipping fake typed array tests because they do not work in FF')
}

// Old Node.js had a fully custom Buffer implementation, newer are based on ArrayBuffer
// This is important for the ArrayBuffer and typed array tests
var isBufferBasedOnArrayBuffer = Buffer.alloc(1).buffer !== undefined;
{
var primitive = function primitive() { return true; };
var arrayBuffer = function arrayBuffer() { return new ArrayBuffer(1); };

var buffer = function buffer() { return Buffer.from(arrayBuffer()); };
var dataView = function dataView() { return new DataView(arrayBuffer()); };
var dataView = function dataView() { return new DataView(arrayBuffer(), 0, 1); };
var uint8Array = function uint8Array() { return new Uint8Array(arrayBuffer()); };
var uint8ClampedArray = function uint8ClampedArray() { return new Uint8ClampedArray(arrayBuffer()); };
var uint16Array = function uint16Array() { return new Uint16Array(arrayBuffer()); };
Expand Down Expand Up @@ -208,7 +221,7 @@ if (SymbolToStringTagSupported) {
var fakeBigUint64Array = function fakeBigUint64Array() { return Object.create(BigUint64Array.prototype); };

var stealthyDataView = function stealthyDataView() {
return Object.setPrototypeOf(new DataView(arrayBuffer()), Uint8Array.prototype);
return Object.setPrototypeOf(new DataView(arrayBuffer(), 0, 1), Uint8Array.prototype);
};
var stealthyUint8Array = function stealthyUint8Array() {
return Object.setPrototypeOf(new Uint8Array(arrayBuffer()), ArrayBuffer.prototype);
Expand Down Expand Up @@ -384,7 +397,7 @@ if (SymbolToStringTagSupported) {

var expected = {
isArrayBufferView: [
buffer,
isBufferBasedOnArrayBuffer ? buffer : undefined,
dataView,
stealthyDataView,
uint8Array,
Expand All @@ -411,7 +424,7 @@ if (SymbolToStringTagSupported) {
stealthyBigUint64Array
],
isTypedArray: [
buffer,
isBufferBasedOnArrayBuffer ? buffer : undefined,
uint8Array,
stealthyUint8Array,
uint8ClampedArray,
Expand All @@ -436,7 +449,7 @@ if (SymbolToStringTagSupported) {
stealthyBigUint64Array
],
isUint8Array: [
buffer,
isBufferBasedOnArrayBuffer ? buffer : undefined,
uint8Array,
stealthyUint8Array
],
Expand Down