-
Notifications
You must be signed in to change notification settings - Fork 1
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async module loading / bundle splitting #6
Comments
From our experience here at Cloudflare, getting |
@terinjokes in your opinion, what could be done to improve this? Any particular parts of integrating it that didn't feel right? |
DescriptionHello all, I can break down what would be ideal — with some explanation as to why — then list out my experiences with using existing libraries and what deficiencies i ran into using them. This is a fairly complex issue so please bear with me, also please by no means take this as gospel. This is just meant to add some ideas about success criteria based on using this approach "in anger" while building a real app. success criteria
partition-bundle discoverypartition-bundle on github For me partition bundle works pretty well. It satisfies almost all of my success criteria save for splitting out page specific css files, but this could be a sheetify plugin concern. The example build file shows passing the main file, entry files as well as a url for local and deployed loading of files with the bundled loadjs factor-bundle discoveryfactor-bundle on github However you would need to come up with your own loader which might be a good idea in that it separates concerns, but it does make it a non-viable option out of the box. Another issue i ran into was it didn't put files into a main entry file with multiple other entry points. In my experience it only separated out shared modules into a common bundle. For me it would be better to have one file that manages common code as well as loading other externalized modules. Anyways, there are some thoughts, hopefully they help. |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
As per #5:
Input on the topic would be greatly appreciated!
cc/ @kristoferjoseph @brianleroux
The text was updated successfully, but these errors were encountered: