Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Q stops working with Browserify >= 8.1.0 due to nextTick changes #1179

Closed
slorber opened this issue Mar 24, 2015 · 3 comments · Fixed by #1231
Closed

Q stops working with Browserify >= 8.1.0 due to nextTick changes #1179

slorber opened this issue Mar 24, 2015 · 3 comments · Fixed by #1231

Comments

@slorber
Copy link

slorber commented Mar 24, 2015

Q works fine with Browserify 8.0.3 but has serious problems since 8.1.0.
This is related to changes done in nextTick implementation of node-process: #1018

Related Q issue: kriskowal/q#669

I don't know who of Q or Browserify should fix this but this makes Q unreliable in production.
This was referenced Mar 24, 2015
Merged
Merged
slorber referenced this issue in defunctzombie/node-process Mar 24, 2015
@calvinmetcalf
simplified next tick
62acf3e
This was referenced Mar 24, 2015
Closed
Closed
@slorber
Copy link
Author

slorber commented Mar 24, 2015

A PR is available here defunctzombie/node-process#37

@slorber
Copy link
Author

slorber commented Apr 25, 2015

@substack @defunctzombie this can now be solved by uprading "process" dependency to 0.11 right?

@zertosh
Copy link
Member

zertosh commented Apr 26, 2015

@slorber It's not just flipping the version. A couple of tests fail for the reasons in browserify/insert-module-globals#42 (under process to ^0.10.0). I'll try to get to it tmw.

@zertosh zertosh mentioned this issue Apr 27, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update process to ~0.11.0
2 participants
@slorber @zertosh