-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zlib's brotli methods are not supported #37
Comments
I also maintain the The encoding part should work in the browser too - it's ported with emscripten. The decoding is hand ported. |
Sadly it doesn't, see foliojs/brotli.js#20. In my app I do use brotli for decoding, but for encoding I use wasm-brotli instead. Works fine, I'm not sure how it compares in detail, but I suspect it won't play nicely anywhere without proper webassembly support. |
Seems fairly safe now, except for IE 11: https://caniuse.com/#feat=wasm. I'd happily accept PRs to fix the browser issues in |
Also, I'm planning on transferring this repo to the |
Any update on this? it seems the |
I had issues with wasm-brotli so I built https://github.com/httptoolkit/brotli-wasm, does that work for you @HeCorr? |
@pimterry Sorry, that's the package I tried (I miswrote the name). I couldn't make it work with Webpack 5 because the project forces me to use |
@pimterry Never mind, the errors I was originally having suddenly went away and I'm getting different errors now (from a different package). |
The zlib module's new (11.7+) brotli methods are not supported. Docs here: https://nodejs.org/api/zlib.html#zlib_class_zlib_brotlicompress.
Presumably this is because Pako doesn't support them? It'd be good to list this in the readme though.
Notably it is possible to at least decode brotli on the web using https://www.npmjs.com/package/brotli. The encode part of that package only works in node though.
The text was updated successfully, but these errors were encountered: