chore: rename browserbaseResumeSessionID -> browserbaseSessionID #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c8ef818 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pkiv
approved these changes
Dec 17, 2024
jtoar
reviewed
Dec 17, 2024
Contributor
jtoar
left a comment
jtoar
left a comment
There was a problem hiding this comment.
to avoid this being a breaking change you probably want to still accept browserbaseResumeSessionID, just mark it as deprecated (can do in the release notes and via typescript js/tsdoc @deprecated i believe) and map it internally to browserbaseSessionID. you may have to also handle the case where both are passed, and browserbaseSessionID would take precedence
seanmcguire12
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
user convenience
what changed
browserbaseResumeSessionId->browserbaseResumeSessionIDtest plan
lint/build