-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modal-prompt.js changes don't get into build #505
Comments
Thanks for writing this down clearly. There are a few workflows that have existed for a while where I have to write I have tended to give up before figuring out why. |
Ah! I see. So then I think the relevant chunk is this target in the Makefile:
Which means that as far as make knows, it should only re-run webpack when that one file changes. I think that target should include dependencies on every file that gets included by the webpack config, so that it knows to re-run webpack if any of them change. I can play around with getting the list exactly right. |
Oh that sure sounds like a reasonable culprit! Please do find the right dependency list if you can; I got bitten by this today and forgot how annoying it was to have to guess which file to |
Problem
If you have an existing build, make changes to
modal-prompt.js
, and then runnpm run build
, in the general case the modal code changes will not be in the resulting build. It appears you have to make changes to some other file (I'm not sure exactly which will work) or completely delete the current build and build from scratch, to ingest the changes.I would like to figure out a fix because I have a bunch of modal changes I want to finish up and the current dev cycle is too slow and painful to get through them.
Research:
Makefile
to understand why.The text was updated successfully, but these errors were encountered: