This repository has been archived by the owner on Jun 17, 2018. It is now read-only.
Changed the TagManager.usage_for_queryset method. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitalyvolkov
pushed a commit
to devua/django-tagging
that referenced
this pull request
Jan 19, 2016
update overview.txt a little
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TagManager.usage_for_queryset obtains a list of tags associated with instances of a model contained in the given queryset.
I needed to filter the result so that Tag.name contains "text".
So I added tag_queryset argument to TagManager.usage_for_queryset and used it's "where" part as extra criteria for TagManager._get_usage() method.
So I use the new argument like this:
Tag.objects.usage_for_queryset(queryset=Car.live.filter(user=request.user), tag_queryset= Tag.objects.filter(name__icontains='text'))