Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vlan and bridge management #54

Closed
wants to merge 1 commit into from
Closed

Added vlan and bridge management #54

wants to merge 1 commit into from

Conversation

signal-09
Copy link
Contributor

Also added -details option to visualize additional link info (e.g. VLAN ID).

Closes #52
Closes #53

@brona
Copy link
Owner

brona commented Jun 17, 2024

Thank you for the contribution, I will look into it during the weekend.

Also added -details option to visualize additional link info (e.g. VLAN ID).

Closes #52
Closes #53
@signal-09 signal-09 closed this Jul 28, 2024
@signal-09 signal-09 deleted the vlan-feature branch July 28, 2024 08:17
@brona
Copy link
Owner

brona commented Jul 31, 2024

Sorry for not getting to this sooner, I am now finishing the 1.5.0 release, Homebrew/homebrew-core#179084, if you want we can get back to adding the VLANs once that is done.

@signal-09
Copy link
Contributor Author

First of all, happy new release!
Don't worry, I started contributing to your project mainly to practice Python (I'm a beginner).
To avoid causing problems to others, accelerate my learning and also practice directly on CI/CD environments, I decided to rewrite the entire project bottom-up in an isolated environment few weeks ago (https://github.com/signal-09/iproute4mac/).
Feel free to reuse anything you think might be useful for your project (also suggestions are welcomed).

@brona
Copy link
Owner

brona commented Aug 2, 2024

That seems like a good idea! Especially if you come up with tests that would be a great direction forward.

Btw see recent commits, there were two bugs in your parse_ifconfig implementation.

@signal-09
Copy link
Contributor Author

Btw see recent commits, there were two bugs in your parse_ifconfig implementation.

I see. Thank you for prompt fixing it.

I worked a lot (as exercise) to reproduce the iproute2 skeleton and UI look&feel in my separated experiment (https://github.com/signal-09/iproute4mac/). On the ip side I suspect I have reach a sort of feature parity with your project, and some extensions like bond, bridge, vlan, and feth (the macOS semi undocumented implementation of Linux veth).

To enforce the code writing style flake8 where used, then switched to ruff, in addition to an embryonic version of pytest for functionality checks.

Most IPv4 & v6 logic where migrated to a Prefix object, derived form ipaddress; so to be able to translate iproute2 filtering (.e.g. to, from, match) with Python native operations (__eq__, __contain__, set() <= set()). My idea is to do the same with back-end commands (ifconfig, netstat, route, etc.) in some future release.

Also tried to imitate exactly the JSON output of iproute2 that, as you already know, is not fully JSON compliant... but that's it.

Needless to say, any kind of input from you is very very appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridge management VLAN support
2 participants