Skip to content

Commit 961aaf6

Browse files
author
Christopher J. Brody
committed
Test comment for 4-byte UTF-8 characters
per string test case, removed from another place ref: storesafe#564
1 parent 87a06a0 commit 961aaf6

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

spec/www/spec/db-tx-string-test.js

+10-7
Original file line numberDiff line numberDiff line change
@@ -1062,13 +1062,6 @@ var mytests = function() {
10621062
});
10631063
}, MYTIMEOUT);
10641064

1065-
// ENCODING BUG REPRODUCED for emojis and other
1066-
// 4-byte UTF-8 characters in SELECT HEX value tests
1067-
// on default Android database access implementation
1068-
// (Android-sqlite-connector with Android-sqlite-ext-native-driver,
1069-
// using NDK) on Android pre-6.0
1070-
// ref: litehelpers/Cordova-sqlite-storage#564
1071-
10721065
it(suiteName + 'string HEX value test with UTF-8 3-byte Samaritan character Bit (U+0801) [default sqlite HEX encoding: UTF-6le on Windows & Android 4.1-4.3 (WebKit) Web SQL, UTF-8 otherwise]', function(done) {
10731066
var db = openDatabase('UTF8-0801-hex-value-test.db');
10741067

@@ -1156,6 +1149,11 @@ var mytests = function() {
11561149
}, MYTIMEOUT);
11571150

11581151
it(suiteName + 'string HEX value test with UTF-8 4-byte Gothic bairkan 𐌱 (U+10331) [XXX ENCODING BUG REPRODUCED on default Android SQLite3 NDK build (using Android-sqlite-connector with Android-sqlite-ext-native-driver) on Android 4.x/5.x; default sqlite HEX encoding: UTF-6le on Windows & Android 4.1-4.3 (WebKit) Web SQL, UTF-8 otherwise]', function(done) {
1152+
// ENCODING BUG REPRODUCED for 4-byte UTF-8 characters
1153+
// on default Android database access implementation
1154+
// (Android-sqlite-connector with Android-sqlite-ext-native-driver,
1155+
// using NDK) on Android pre-6.0
1156+
// ref: litehelpers/Cordova-sqlite-storage#564
11591157
var db = openDatabase('UTF8-2050-hex-value-test.db');
11601158

11611159
db.transaction(function(tx) {
@@ -1278,6 +1276,11 @@ var mytests = function() {
12781276
}, MYTIMEOUT);
12791277

12801278
it(suiteName + 'emoji HEX test: SELECT HEX("@\\uD83D\\uDE03!") [\\u1F603 SMILING FACE (MOUTH OPEN)] [XXX TBD HEX encoding BUG REPRODUCED default Android SQLite3 NDK build (using Android-sqlite-connector with Android-sqlite-ext-native-driver) on Android 4.x & 5.x; default sqlite HEX encoding: UTF-6le on Windows & Android 4.1-4.3 (WebKit) Web SQL, UTF-8 otherwise]', function(done) {
1279+
// ENCODING BUG REPRODUCED for emojis and other 4-byte UTF-8
1280+
// characters on default Android database access implementation
1281+
// (Android-sqlite-connector with Android-sqlite-ext-native-driver,
1282+
// using NDK) on Android pre-6.0
1283+
// ref: litehelpers/Cordova-sqlite-storage#564
12811284
var db = openDatabase('emoji-select-hex-value-test.db');
12821285
expect(db).toBeDefined();
12831286

0 commit comments

Comments
 (0)