Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error loading JSON should abort site build #6

Open
davidc opened this issue Oct 7, 2020 · 2 comments
Open

Error loading JSON should abort site build #6

davidc opened this issue Oct 7, 2020 · 2 comments

Comments

@davidc
Copy link

davidc commented Oct 7, 2020

At the moment if there's an error loading the JSON (e.g. 404), there is no error printed, and the site build continues as if nothing had gone wrong. It should abort so that whatever is building the site doesn't then deploy a broken site.

@brockfanning
Copy link
Owner

This sounds reasonable to me. I wonder if that behavior should be optional, since it may cause some existing projects to begin failing. Or, should we just make the change - probably as part of a minor (or major?) version bump?

@davidc
Copy link
Author

davidc commented Nov 5, 2020

I'm not sure I can imagine a scenario where someone would want to proceed and build a broken site rather than abort, but yes a version bump would be reasonable!

If someone does come up with a use case for that, a new "ignore_load_errors" type key in the yaml could be added to let it continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants