Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connected the splice site window size to CLI parameters. #8463

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Connected the splice site window size to CLI parameters. #8463

merged 4 commits into from
Aug 11, 2023

Conversation

jonn-smith
Copy link
Collaborator

Fixes #8276

@jonn-smith jonn-smith mentioned this pull request Aug 10, 2023
Closed
droazen
droazen approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonn-smith Look fine to me -- I made a few small comments / suggestions

...in/java/org/broadinstitute/hellbender/tools/funcotator/BaseFuncotatorArgumentCollection.java Show resolved Hide resolved
...java/org/broadinstitute/hellbender/tools/funcotator/mafOutput/MafOutputRendererUnitTest.java Show resolved Hide resolved
@droazen droazen assigned jonn-smith and unassigned droazen Aug 10, 2023
@gatk-bot
Copy link

gatk-bot commented Aug 10, 2023 •
edited
Loading

Github actions tests reported job failures from actions build 5823579343
Failures in the following jobs:

Test Type JDK Job ID Logs
unit 17.0.6+10 5823579343.12 logs
unit 17.0.6+10 5823579343.1 logs

@gatk-bot
Copy link

gatk-bot commented Aug 10, 2023 •
edited
Loading

Github actions tests reported job failures from actions build 5823634733
Failures in the following jobs:

Test Type JDK Job ID Logs
unit 17.0.6+10 5823634733.12 logs
unit 17.0.6+10 5823634733.1 logs

@jonn-smith jonn-smith merged commit 4212fdf into master Aug 11, 2023
@jonn-smith jonn-smith deleted the jts_funcotator_splice_window_cli_arg_8276 branch August 11, 2023 11:27
rickymagner pushed a commit that referenced this pull request Nov 28, 2023
@jonn-smith @rickymagner
Funcotator: Connected the splice site window size to CLI parameters. (#…
ed33e87 
…8463)

* Funcotator: Connected the splice site window size to CLI parameters.

Fixes #8276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droazen droazen droazen approved these changes

Assignees

@jonn-smith jonn-smith

Labels
Funcotator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Funcotator - Cannot set splice site window size from CLI
3 participants
@jonn-smith @gatk-bot @droazen