Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small addition to FeatureMap tool #8347

Merged

Conversation

ilyasoifer
Copy link
Collaborator

the number of reads in the locus that pass the FeatureMap filters, regardless of whether the considered base matches the reference or not

@ilyasoifer ilyasoifer self-assigned this May 30, 2023
@ilyasoifer ilyasoifer requested a review from meganshand June 26, 2023 14:52
Copy link
Contributor

@meganshand meganshand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 once tests pass

@ilyasoifer
Copy link
Collaborator Author

@meganshand - do you want me to re-run the tests that failed (seem unrelated)?

@meganshand
Copy link
Contributor

@jamesemery are these test failures expected/known? They seem unrelated to this PR.

@cmnbroad
Copy link
Collaborator

cmnbroad commented Jun 27, 2023

@ilyasoifer @meganshand @jamesemery It looks like these are the same out-of-space issues we've been seeing elsewhere - there is a fix on master. If you rebase they should go away.

 the number of reads in the locus that pass the FeatureMap filters, regardless of whether the considered base matches the reference or not
@ilyasoifer ilyasoifer force-pushed the ultima.feature-map.develop branch from 90e1932 to 4495942 Compare July 2, 2023 06:28
@ilyasoifer
Copy link
Collaborator Author

Thanks all!

@ilyasoifer ilyasoifer merged commit c068947 into broadinstitute:master Jul 2, 2023
@ilyasoifer ilyasoifer deleted the ultima.feature-map.develop branch July 2, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants