Updates to reduce size of docker #8259
Conversation
|
@droazen This reduces the size of the final compressed docker image from 2.86 -> 2.11 GB which seems worthwhile. |
|
I need to retag and rename the base image before merging this but if you want to take a look it would be good. |
| @@ -35,6 +35,7 @@ RUN echo "deb [signed-by=/usr/share/keyrings/cloud.google.gpg] http://packages.c | |||
| apt-get -y clean && \ | |||
| apt-get -y autoclean && \ | |||
| apt-get -y autoremove && \ | |||
| rm -rf /usr/lib/google-cloud-sdk/bin/anthoscli /usr/lib/google-cloud-sdk/platform/anthoscli_licenses /usr/lib/google-cloud-sdk/platform/bundledpythonunix && \ | |||
There was a problem hiding this comment.
Add a comment explaining why these are explicitly removed
There was a problem hiding this comment.
Done. They're giant, we don't use them, and removing them doesn't seem to cause problems.
scripts/docker/gatkbase/Dockerfile
Outdated
| @@ -50,18 +51,19 @@ ENV JAVA_LIBRARY_PATH /usr/lib/jni | |||
|
|
|||
| # Install miniconda | |||
| ENV DOWNLOAD_DIR /downloads | |||
| ENV CONDA_URL https://repo.continuum.io/miniconda/Miniconda3-4.7.12.1-Linux-x86_64.sh | |||
| ENV CONDA_MD5 = "81c773ff87af5cfac79ab862942ab6b3" | |||
| ENV CONDA_URL https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh | |||
There was a problem hiding this comment.
Is it safe for us to use latest instead of a tagged version?
There was a problem hiding this comment.
It's a good question. We were previously having problems because it was too old, but maybe using latest all the time is over compensating.
There was a problem hiding this comment.
With further thought the answer is "no", because we are hardcoding the hash here as well. I've pinned it.
No description provided.