Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to specify the RELEASE arg in build_docker_remote.sh, and add a release_prebuilt_docker_image.sh script #8247

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Add ability to specify the RELEASE arg in build_docker_remote.sh, and add a release_prebuilt_docker_image.sh script #8247

merged 1 commit into from
Dec 13, 2023

Conversation

droazen
Copy link
Contributor

@droazen droazen commented Mar 17, 2023

No description provided.

@droazen droazen force-pushed the dr_docker_cloud_release_arg branch 4 times, most recently from 040a147 to 7849e19 Compare March 17, 2023 20:53
@droazen
Copy link
Contributor Author

droazen commented Mar 17, 2023

I used the updated scripts in this PR to successfully push the 4.4.0.0 release image, so these are confirmed to be working correctly.

@jamesemery jamesemery self-requested a review March 20, 2023 15:18
jamesemery
jamesemery reviewed Mar 20, 2023
View reviewed changes
build_docker_remote.sh Outdated
echo "Building image with the tag ${DOCKER_IMAGE_TAG}..."

SUBMIT_COMMAND="gcloud builds submit --tag ${DOCKER_IMAGE_TAG} --timeout=24h --machine-type n1_highcpu_8"
if [ -n "$RELEASE" ]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make these use the same arguments? I don't like that the tag is getting set with the --tag in one place, whereas in the other you are using a push "tag" inside of the build using the build.yml. These two codepaths are very incompatable and it seems dangerous to not have them unified. Please push the tagging for the non-release into the .yml file so we are at least beholden to the same mechanism failing.

Copy link
Contributor Author

@droazen droazen Mar 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@droazen
Copy link
Contributor Author

droazen commented Mar 22, 2023

Looking into finding a way to enable experimental docker features for gcr.io/cloud-builders/docker so that we can run with the --squash argument -- it's not yet clear that this is possible.

@droazen
Copy link
Contributor Author

droazen commented Mar 22, 2023

Had to remove the --squash argument, as I couldn't get it to work with either gcr.io/cloud-builders/docker or docker.io/library/docker. We'll have to address the issue of image size in separate PRs.

jamesemery
jamesemery approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@jamesemery jamesemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks better provided that you've tested and the default tagging is working for your use case. This is a more... confusing... way of propagating the tag but at least its consistent.

@droazen
build_docker_remote: add ability to specify the RELEASE arg to the cl…
6fa35a0 
…oud-based docker build, and add a release script

* Added a -r argument to build_docker_remote.sh to toggle the RELEASE flag during
  docker builds

* Added a release_prebuilt_docker_image.sh to release a prebuilt docker image to the
  official repos
@droazen droazen force-pushed the dr_docker_cloud_release_arg branch from f2ad2d6 to 6fa35a0 Compare December 13, 2023 17:29
@droazen droazen changed the title build_docker_remote: add ability to specify the RELEASE arg to the cloud-based docker build Add ability to specify the RELEASE arg in build_docker_remote.sh, and add a release_prebuilt_docker_image.sh script Dec 13, 2023
@droazen droazen merged commit 75f5104 into master Dec 13, 2023
20 checks passed
@droazen droazen deleted the dr_docker_cloud_release_arg branch December 13, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesemery jamesemery jamesemery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@droazen @jamesemery