Fix deprecations in Github Actions #8241
Conversation
lbergelson
commented
Mar 14, 2023
•
lbergelson
commented
- Change actions v2 -> v3
- Fixing deprecated set-output usage see https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
There was a problem hiding this comment.
This all looks good (i'm assuming the V3 actions release is at least one more version better)... the bigger concern i have is to make sure those ::set-output ....:: commands are still doing what they were intended to do. Did they change the for output variables being visible to other jobs recently or did we simply chose a confusing way of doing it in the first place?
Most of the ones you changed are related to the logs URL variables, can you check to be 100% sure that those links work now?
| @@ -32,15 +32,15 @@ jobs: | |||
| env: | |||
| GCP_CREDENTIALS: ${{ secrets.GCP_CREDENTIALS }} | |||
| if: "${{ env.GCP_CREDENTIALS != '' }}" | |||
| run: echo "::set-output name=defined::true" | |||
| run: echo defined=true >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
These still work for outputs? I remember I had to use those eldrich invocations as messy as they were to pass variables across jobs.
There was a problem hiding this comment.
It seems to work. The jobs are passing...
There was a problem hiding this comment.
Bleh the report upload link looks broken now?
https://storage.googleapis.com/hellbender-test-logs/build_reports/8241/merge_4420157996.1/tests/testOnPackagedReleaseJar/index.html
There was a problem hiding this comment.
Well on the plus side it looks like it was already broken to follow the index.html link posted by a run job...
lbergelson
force-pushed
the
lb_fix_deprecation_in_actions
branch
from
c031bdc to
6ace50c
Compare
|
All warnings are gone now. Going to merge this. |
