You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The BCFCodec in the next release of htsjdk (after 2.19) will reject any BCF input that is greater than BCF 2.1 (see #5838 and samtools/htsjdk#1323). However, GenomicsDB uses htslib, which generates version 2.2 output, to create BCF streams for GATK (with the BCF IDX fields removed). This will no longer work with post-2.19 htsjdk versions.
Since GATK bypasses codec discovery and provides the codec directly for GenomicsDB inputs, the proposed solution is to change to the BCF codec in htsjdk to delegate version checking to an overridable method(!), and then provide a subclassed codec in GATK that has relaxed version checking.
The text was updated successfully, but these errors were encountered:
cmnbroad
changed the title
Create a subclass of BCFCodec used when reading from GenomicsDB
Create a subclass of BCFCodec for use when reading from GenomicsDB
Mar 26, 2019
cmnbroad
changed the title
Create a subclass of BCFCodec for use when reading from GenomicsDB
Subclass BCFCodec for use when reading from GenomicsDB
Mar 26, 2019
The htsjdk branch for this is here and the GATK branch is here. We'll need this for the next (post 2.19) htsjdk update. Will require the htsjdk branch to be merged and released before we can use the GATK branch.
The BCFCodec in the next release of htsjdk (after 2.19) will reject any BCF input that is greater than BCF 2.1 (see #5838 and samtools/htsjdk#1323). However, GenomicsDB uses htslib, which generates version 2.2 output, to create BCF streams for GATK (with the BCF IDX fields removed). This will no longer work with post-2.19 htsjdk versions.
Since GATK bypasses codec discovery and provides the codec directly for GenomicsDB inputs, the proposed solution is to change to the BCF codec in htsjdk to delegate version checking to an overridable method(!), and then provide a subclassed codec in GATK that has relaxed version checking.
The text was updated successfully, but these errors were encountered: