Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subclass BCFCodec for use when reading from GenomicsDB #5839

Closed
cmnbroad opened this issue Mar 26, 2019 · 2 comments
Closed

Subclass BCFCodec for use when reading from GenomicsDB #5839

cmnbroad opened this issue Mar 26, 2019 · 2 comments
Assignees
Labels

Comments

@cmnbroad
Copy link
Collaborator

The BCFCodec in the next release of htsjdk (after 2.19) will reject any BCF input that is greater than BCF 2.1 (see #5838 and samtools/htsjdk#1323). However, GenomicsDB uses htslib, which generates version 2.2 output, to create BCF streams for GATK (with the BCF IDX fields removed). This will no longer work with post-2.19 htsjdk versions.

Since GATK bypasses codec discovery and provides the codec directly for GenomicsDB inputs, the proposed solution is to change to the BCF codec in htsjdk to delegate version checking to an overridable method(!), and then provide a subclassed codec in GATK that has relaxed version checking.

@cmnbroad cmnbroad self-assigned this Mar 26, 2019
@cmnbroad cmnbroad changed the title Create a subclass of BCFCodec used when reading from GenomicsDB Create a subclass of BCFCodec for use when reading from GenomicsDB Mar 26, 2019
@cmnbroad cmnbroad changed the title Create a subclass of BCFCodec for use when reading from GenomicsDB Subclass BCFCodec for use when reading from GenomicsDB Mar 26, 2019
@droazen droazen added this to the Engine-Q2-2019 milestone Mar 27, 2019
@droazen droazen added the HTSJDK label Mar 27, 2019
@cmnbroad
Copy link
Collaborator Author

cmnbroad commented Mar 27, 2019

The htsjdk branch for this is here and the GATK branch is here. We'll need this for the next (post 2.19) htsjdk update. Will require the htsjdk branch to be merged and released before we can use the GATK branch.

@cmnbroad
Copy link
Collaborator Author

Done long ago #6305.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants