Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Project.getConvention() method has been deprecated. #166

Closed
Goooler opened this issue Nov 7, 2023 · 3 comments · Fixed by #167
Closed

The Project.getConvention() method has been deprecated. #166

Goooler opened this issue Nov 7, 2023 · 3 comments · Fixed by #167
Milestone

Comments

@Goooler
Copy link
Contributor

Goooler commented Nov 7, 2023

DefaultMavenPluginDevelopmentExtension.kt:69	
  at org.gradle.api.internal.project.DefaultProject.getConvention(DefaultProject.java:593)	
  at de.benediktritter.maven.plugin.development.internal.DefaultMavenPluginDevelopmentExtension$pluginSourceSet$1.call(DefaultMavenPluginDevelopmentExtension.kt:69)	
  at de.benediktritter.maven.plugin.development.internal.DefaultMavenPluginDevelopmentExtension$pluginSourceSet$1.call(DefaultMavenPluginDevelopmentExtension.kt:34)	
  at org.gradle.api.internal.provider.DefaultProvider.calculateOwnValue(DefaultProvider.java:72)	
  at org.gradle.api.internal.provider.AbstractMinimalProvider.calculateValue(AbstractMinimalProvider.java:115)
MavenPluginDevelopmentPlugin.kt:154	
  at org.gradle.api.internal.project.DefaultProject.getConvention(DefaultProject.java:593)	
  at de.benediktritter.maven.plugin.development.MavenPluginDevelopmentPlugin$apply$1$generateTask$1$4.call(MavenPluginDevelopmentPlugin.kt:154)	
  at de.benediktritter.maven.plugin.development.MavenPluginDevelopmentPlugin$apply$1$generateTask$1$4.call(MavenPluginDevelopmentPlugin.kt:85)	
  at org.gradle.api.internal.provider.DefaultProvider.calculateOwnValue(DefaultProvider.java:72)	
  at org.gradle.api.internal.provider.AbstractMinimalProvider.calculateValue(AbstractMinimalProvider.java:115)	
@britter
Copy link
Member

britter commented Feb 21, 2024

I can reproduce this in sample/gradle-producer-build but I'm currently unable to write a test that fails because of the deprecations.

@britter
Copy link
Member

britter commented Feb 21, 2024

Tried to write a test in #200 but without success. Need to dig deeper.

@Goooler
Copy link
Contributor Author

Goooler commented Feb 22, 2024

This is a convention invocation from older Gradle but has been polished in newer versions, check
https://github.com/gradle/gradle/blob/1cf537a851c635c364a4214885f8b9798051175b/subprojects/kotlin-dsl/src/main/kotlin/org/gradle/kotlin/dsl/ProjectExtensions.kt#L100-L112

I believe we can just replace the usages in #167 without any test case.

@britter britter added this to the 0.4.3 milestone Feb 28, 2024
britter added a commit that referenced this issue Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants