telefunc/vite doesn't read the root project

[rtritto]

Telefunc Vite plugin doesn't use viteConfig.root to load the Vite root that points to ./src instead of ./.

Reproduction

• Clone template-vike-solid-daisyui-hono#telefunc-resolve (minimal reproduction with copy of template-vike-solid-daisyui-hono#minimal with PnP support patch of Support Yarn PnP #77)
• yarn
• yarn dev
• Go to http://localhost:3000
• Click on button "Click me to Test Telefunc"

  Vike v0.4.220  ready in 2562 ms
  ➜  press h + enter to show help
Server running at http://localhost:3000
23:57:21 [vike][request(1)] HTTP request: /
23:57:21 [vike][request(1)] HTTP response / 200
[[email protected]][Warning] We recommend the name of your telefunction default() (/_telefunc/testTelefunc.telefunc.ts) to start with "on", see https://telefunc.com/event-based#naming-convention'
Error: ENOENT: no such file or directory, scandir 'C:\template-vike-solid-daisyui-hono\_telefunc'
    at Object.readdirSync (node:fs:1502:26)
    at NodeFS.readdirSync (C:\template-vike-solid-daisyui-hono\.pnp.cjs:6236:26)
    at makeCallSync.subPath.subPath (C:\template-vike-solid-daisyui-hono\.pnp.cjs:6914:26)
    at ZipOpenFS.makeCallSync (C:\template-vike-solid-daisyui-hono\.pnp.cjs:7020:14)
    at ZipOpenFS.readdirSync (C:\template-vike-solid-daisyui-hono\.pnp.cjs:6913:17)
    at VirtualFS.readdirSync (C:\template-vike-solid-daisyui-hono\.pnp.cjs:5817:24)
    at PosixFS.readdirSync (C:\template-vike-solid-daisyui-hono\.pnp.cjs:5817:24)
    at NodePathFS.readdirSync (C:\template-vike-solid-daisyui-hono\.pnp.cjs:5817:24)
    at assertCollocation (C:\template-vike-solid-daisyui-hono\.yarn\__virtual__\telefunc-virtual-1154c1b1f4\4\Users\<USER>\AppData\Local\Yarn\Berry\cache\telefunc-patch-73b7fb8a6a-10c0.zip\node_modules\telefunc\dist\cjs\node\server\runTelefunc\assertNamingConvention.js:48:32)
    at assertNamingConvention (C:\template-vike-solid-daisyui-hono\.yarn\__virtual__\telefunc-virtual-1154c1b1f4\4\Users\<USER>\AppData\Local\Yarn\Berry\cache\telefunc-patch-73b7fb8a6a-10c0.zip\node_modules\telefunc\dist\cjs\node\server\runTelefunc\assertNamingConvention.js:9:5)
    at C:\template-vike-solid-daisyui-hono\.yarn\__virtual__\telefunc-virtual-1154c1b1f4\4\Users\<USER>\AppData\Local\Yarn\Berry\cache\telefunc-patch-73b7fb8a6a-10c0.zip\node_modules\telefunc\dist\cjs\node\server\runTelefunc\findTelefunction.js:28:65
    at findTelefunction (C:\template-vike-solid-daisyui-hono\.yarn\__virtual__\telefunc-virtual-1154c1b1f4\4\Users\<USER>\AppData\Local\Yarn\Berry\cache\telefunc-patch-73b7fb8a6a-10c0.zip\node_modules\telefunc\dist\cjs\node\server\runTelefunc\findTelefunction.js:31:7)
    at runTelefunc_ (C:\template-vike-solid-daisyui-hono\.yarn\__virtual__\telefunc-virtual-1154c1b1f4\4\Users\<USER>\AppData\Local\Yarn\Berry\cache\telefunc-patch-73b7fb8a6a-10c0.zip\node_modules\telefunc\dist\cjs\node\server\runTelefunc.js:87:70)
    at runTelefunc (C:\template-vike-solid-daisyui-hono\.yarn\__virtual__\telefunc-virtual-1154c1b1f4\4\Users\<USER>\AppData\Local\Yarn\Berry\cache\telefunc-patch-73b7fb8a6a-10c0.zip\node_modules\telefunc\dist\cjs\node\server\runTelefunc.js:38:16)
    at telefunc (C:\template-vike-solid-daisyui-hono\.yarn\__virtual__\telefunc-virtual-1154c1b1f4\4\Users\<USER>\AppData\Local\Yarn\Berry\cache\telefunc-patch-73b7fb8a6a-10c0.zip\node_modules\telefunc\dist\cjs\node\server\telefunc.js:11:26)
    at telefuncHandler (C:\template-vike-solid-daisyui-hono\src\server\telefunc-handler.ts:5:24)
    at dispatch (file:///C:/Users/<USER>/AppData/Local/Yarn/Berry/cache/hono-npm-4.6.20-476f4e6f76-10c0.zip/node_modules/hono/dist/compose.js:30:17)
    at file:///C:/Users/<USER>/AppData/Local/Yarn/Berry/cache/hono-npm-4.6.20-476f4e6f76-10c0.zip/node_modules/hono/dist/hono-base.js:195:25
    at responseViaResponseObject (file:///C:/template-vike-solid-daisyui-hono/.yarn/__virtual__/@hono-node-server-virtual-062fe8956e/4/Users/<USER>/AppData/Local/Yarn/Berry/cache/@hono-node-server-npm-1.13.8-8f90b77492-10c0.zip/node_modules/@hono/node-server/dist/index.mjs:351:13)

[brillout]

Is that related to Yarn PnP? Can you reproduce it with pnpm instead of Yarn?

[rtritto]

Is that related to Yarn PnP?

No.

Can you reproduce it with pnpm instead of Yarn?

Yes, I will add the repro with pnpm.

[brillout]

👍 Neat, looking forward to it.

[rtritto]

Branch updated

  Vike v0.4.220  ready in 904 ms
  ➜  press h + enter to show help
Server running at http://localhost:3000
19:55:09 [vike][request(1)] HTTP request: /
19:55:09 [vike][request(1)] HTTP response / 200
[[email protected]][Warning] We recommend the name of your telefunction default() (/_telefunc/testTelefunc.telefunc.ts) to start with "on", see https://telefunc.com/event-based#naming-convention'
Error: ENOENT: no such file or directory, scandir 'C:\template-vike-solid-daisyui-hono\_telefunc'
    at Object.readdirSync (node:fs:1502:26)
    at assertCollocation (C:\template-vike-solid-daisyui-hono\node_modules\.pnpm\[email protected]_@[email protected]_@[email protected]_@[email protected]\node_modules\telefunc\dist\cjs\node\server\runTelefunc\assertNamingConvention.js:48:32)
    at assertNamingConvention (C:\template-vike-solid-daisyui-hono\node_modules\.pnpm\[email protected]_@[email protected]_@[email protected]_@[email protected]\node_modules\telefunc\dist\cjs\node\server\runTelefunc\assertNamingConvention.js:9:5)
    at C:\template-vike-solid-daisyui-hono\node_modules\.pnpm\[email protected]_@[email protected]_@[email protected]_@[email protected]\node_modules\telefunc\dist\cjs\node\server\runTelefunc\findTelefunction.js:28:65
    at findTelefunction (C:\template-vike-solid-daisyui-hono\node_modules\.pnpm\[email protected]_@[email protected]_@[email protected]_@[email protected]\node_modules\telefunc\dist\cjs\node\server\runTelefunc\findTelefunction.js:31:7)
    at runTelefunc_ (C:\template-vike-solid-daisyui-hono\node_modules\.pnpm\[email protected]_@[email protected]_@[email protected]_@[email protected]\node_modules\telefunc\dist\cjs\node\server\runTelefunc.js:87:70)
    at runTelefunc (C:\template-vike-solid-daisyui-hono\node_modules\.pnpm\[email protected]_@[email protected]_@[email protected]_@[email protected]\node_modules\telefunc\dist\cjs\node\server\runTelefunc.js:38:16)
    at telefunc (C:\template-vike-solid-daisyui-hono\node_modules\.pnpm\[email protected]_@[email protected]_@[email protected]_@[email protected]\node_modules\telefunc\dist\cjs\node\server\telefunc.js:11:26)
    at telefuncHandler (C:\template-vike-solid-daisyui-hono\src\server\telefunc-handler.ts:5:24)
    at dispatch (file:///C:/template-vike-solid-daisyui-hono/node_modules/.pnpm/[email protected]/node_modules/hono/dist/compose.js:30:17)     
    at file:///C:/template-vike-solid-daisyui-hono/node_modules/.pnpm/[email protected]/node_modules/hono/dist/hono-base.js:195:25
    at responseViaResponseObject (file:///C:/template-vike-solid-daisyui-hono/node_modules/.pnpm/@[email protected][email protected]/node_modules/@hono/node-server/dist/index.mjs:351:13)

[brillout]

I could reproduce 👍 Nice minimal reproduction.

I'll take a stab at it next week (or PR welcome if that's something you'd be up for; see

telefunc/telefunc/node/server/runTelefunc.ts

Line 112 in b8a3c28

const { telefuncFilesLoaded, telefuncFilesAll } = await loadTelefuncFiles(runContext)

and

telefunc/telefunc/node/vite/loadTelefuncFilesWithVite.ts

Line 29 in b8a3c28

const viteDevServer = getViteDevServer()

which I believe exposes viteDevServer.config.root).

In the meantime I think https://telefunc.com/root may do the trick?

[brillout]

I'm quite busy wit high priorities, so I'm de-prioritizing this since it has a workaround. PR welcome though.