Setup minify error messages #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
commented
Sep 5, 2025
Janpot
commented
- I have followed (at least) the PR section of the contributing guide.
…isplay.tsx Co-authored-by: Michał Dudak <[email protected]> Signed-off-by: Jan Potoms <[email protected]>
Co-authored-by: atomiks <[email protected]> Signed-off-by: Jan Potoms <[email protected]>
…ntent.mdx Co-authored-by: atomiks <[email protected]> Signed-off-by: Jan Potoms <[email protected]>
Signed-off-by: Jan Potoms <[email protected]>
brijeshb42
reviewed
Sep 5, 2025
| import * as React from 'react'; | ||
| import { notFound } from 'next/navigation'; | ||
| import PageContent from './PageContent.mdx'; | ||
| import codes from '../../../../../error-codes.json'; |
Owner
There was a problem hiding this comment.
import codes from 'docs/src/error-codes.json';
brijeshb42
reviewed
Sep 5, 2025
| * ... | ||
| * @param {number} code | ||
| */ | ||
| export default function formatErrorMessage(code: number, ...args: string[]): string { |
Owner
There was a problem hiding this comment.
This should be part of utils package and used within utils package as well as the react package since the extraction runs on both the packages.
brijeshb42
force-pushed
the
error-code-extraction
branch
4 times, most recently
from
d936046 to
2dbc69c
Compare
brijeshb42
force-pushed
the
error-code-extraction
branch
4 times, most recently
from
3e1029c to
4a7124d
Compare
brijeshb42
force-pushed
the
error-code-extraction
branch
2 times, most recently
from
187001a to
43d8fdd
Compare
Co-authored-by: Olivier Tassinari <[email protected]> Signed-off-by: Jan Potoms <[email protected]>
Co-authored-by: Olivier Tassinari <[email protected]> Signed-off-by: Jan Potoms <[email protected]>
brijeshb42
force-pushed
the
error-code-extraction
branch
from
0a4803a to
4e1c986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.