fix(arm): Fix arm graph breadcrumbs #6869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omriyoffe-panw
requested a deployment
to
scan-security
GitHub Actions
Waiting
omriyoffe-panw
changed the title
lirshindalman
approved these changes
Nov 24, 2024
bo156
reviewed
Nov 24, 2024
omriyoffe-panw
requested a deployment
to
scan-security
GitHub Actions
Waiting
bo156
reviewed
Nov 24, 2024
checkov/arm/runner.py
Outdated
| @@ -138,6 +140,7 @@ def add_python_check_results(self, report: Report, runner_filter: RunnerFilter, | |||
| path_to_convert = (os.path.join(root_folder, arm_file)) if root_folder else arm_file | |||
|
|
|||
| file_abs_path = os.path.abspath(path_to_convert) | |||
| cleaned_path = clean_file_path(Path(arm_file)) | |||
There was a problem hiding this comment.
@omriyoffe-panw could you also add a test to check this use-case?
There was a problem hiding this comment.
I reverted this change since the python checks are not relevant for the custom policies preview flow
omriyoffe-panw
requested a deployment
to
scan-security
GitHub Actions
Waiting
omriyoffe-panw
requested a deployment
to
scan-security
GitHub Actions
Waiting
omriyoffe-panw
temporarily deployed
to
scan-security
GitHub Actions
Inactive
bo156
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Refactor the
Runnerclass incheckov/arm/runner.pyto improve file path handling and breadcrumb integration. Introduceclean_file_pathincheckov/arm/utils.pyto sanitize file paths. Enhance breadcrumb functionality by incorporatingGraphRecordfor better tracking of resources in the ARM graph.Runnerclass by usingclean_file_pathto sanitize paths andextract_file_path_from_abs_pathto convert absolute paths to relative paths.Modified files (2)
Latest Contributors(2)
Runnerclass by integratingGraphRecordto track resources more effectively.Modified files (1)
Latest Contributors(2)