Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate clippy into the build system and Continuous Integration (CI) #448

Closed
briansmith opened this issue Feb 3, 2017 · 1 comment
Closed

Comments

@briansmith
Copy link
Owner

#277 shows that Clippy is useful. We should integrate it into the build system and/or the continuous integration so that we can catch problems before they get committed.

On Continue Integration, Clippy checks should run AFTER the tests. I think it would be too annoying to have a push fail to even run the tests because of a formatting error.

It's probably best to use the cargo clippy subcommand instead of the compiler plugin, as I suspect it would be less brittle and more likely to work across stable/beta/nightly Rust.

@briansmith
Copy link
Owner Author

See https://github.com/Manishearth/rust-clippy/issues/902 regarding the bug where Clippy warns about backticks for path components of URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant